Skip to content

Bug fix for DESCRIBE with a schema name #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Bug fix for DESCRIBE with a schema name #2691

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a881864
Added schema to SHOW COLUMNS
zachmu Oct 9, 2024
7fa1df4
Merge branch 'zachmu/show-table-schema' of github.com:dolthub/go-mysq…
zachmu Oct 9, 2024
16d1ab3
[ga-format-pr] Run ./format_repo.sh to fix formatting
zachmu Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sql/planbuilder/show.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,13 +717,18 @@ func (b *Builder) buildShowAllColumns(inScope *scope, s *ast.Show) (outScope *sc
}

var dbName string
var schemaName string
if s.ShowTablesOpt != nil && s.ShowTablesOpt.DbName != "" {
dbName = s.ShowTablesOpt.DbName
} else if s.Table.DbQualifier.String() != "" {
dbName = s.Table.DbQualifier.String()
}

tableScope, ok := b.buildResolvedTable(inScope, dbName, "", s.Table.Name.String(), asOf)
if s.ShowTablesOpt != nil && s.ShowTablesOpt.SchemaName != "" {
schemaName = s.ShowTablesOpt.SchemaName
}

tableScope, ok := b.buildResolvedTable(inScope, dbName, schemaName, s.Table.Name.String(), asOf)
if !ok {
err := sql.ErrTableNotFound.New(s.Table.Name.String())
b.handleErr(err)
Expand Down