move wrapTriggerRollback logic
#2720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Oct 28, 2024
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
LGTM, one minor comment for perf
sql/rowexec/dml_iters.go
Outdated
| savePointName string | ||
| } | ||
|
|
||
| func containsTrigger(node sql.Node) bool { |
Contributor
There was a problem hiding this comment.
This is a good use case for query flags. When we build a trigger in planbuilder mark a trigger use, and then read that back instead of traversing the node.
added 2 commits
October 28, 2024 11:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
plan.TriggerRollbackandplan.NoopTriggerRollbacknode and applies thetriggerRollbackIterdirectly.When there are multiple nested triggers (aka triggers that call other triggers), we used to have multiple nested trigger rollbacks with different savepoints. It turns out that was unnecessary and a single savepoint at the top of the iter tree is enough; when there's an error, it propagates back to the top, rollingback all changes.