Additional support for vector indexes. #2721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktobey
force-pushed
the
nicktobey/vector2
branch
from
22f2018 to
93103d3
Compare
…unctionExpression and CreateFunc2Args interfaces.
…ISTANCE functions.
…ressions that use vector indexes.
nicktobey
force-pushed
the
nicktobey/vector2
branch
from
3e155ec to
2c88f05
Compare
Contributor
Author
|
Dolt bump here: dolthub/dolt#8516 |
jycor
approved these changes
Nov 7, 2024
Contributor
jycor
left a comment
jycor
left a comment
There was a problem hiding this comment.
Small comments, but overall LGTM!
max-hoffman
approved these changes
Nov 8, 2024
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
LGTM, nothing in particular stands out
Co-authored-by: James Cor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the vector function VEC_DISTANCE to GMS, as well as support for adding and altering vector indexes, and support for
SHOW CREATEon tables with vector indexes.Vector indexes are not yet supported in Dolt. The corresponding version bump in Dolt will have checks preventing vector indexes from being added to Dolt tables.