Use vector index when the SELECT cause has a projection.
#2817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… nodes even if they weren't converted into TopN nodes.
nicktobey
force-pushed
the
nicktobey/vector2
branch
from
da8f6e0 to
02f3d5e
Compare
max-hoffman
approved these changes
Jan 15, 2025
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
I know we are testing the plan implicitly, also adding a query plan test might make future refactors easier.
This was referenced Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some overly strict pattern matching in the vector index selection, we weren't always using the index when there was a projection involved: we were only applying the index in the presence of a
TopNnode, but we also weren't generatingTopNnodes in the case we had aLimit -> Project -> Sortnode structure.I was hoping that #2813 would fix this, and I suspect there's improvements to GMS that would make this unnecessary. But for now, we should allow the pattern matching in
replaceIdxOrderByDistanceto apply a vector index lookup in this case.