Skip to content

Bug fixes for serializing certain types in column default expressions #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Bug fixes for serializing certain types in column default expressions #2825

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f328e13
Fixed a couple bugs in column default normalization: 1) editing the e…
zachmu Jan 22, 2025
88dcda4
[ga-format-pr] Run ./format_repo.sh to fix formatting
zachmu Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions sql/analyzer/resolve_column_defaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,13 +438,27 @@ func normalizeDefault(ctx *sql.Context, colDefault *sql.ColumnDefaultValue) (sql
return colDefault, transform.SameTree, nil
}
typ := colDefault.Type()
if types.IsTime(typ) || types.IsTimespan(typ) || types.IsEnum(typ) || types.IsSet(typ) || types.IsJSON(typ) {
if skipDefaultNormalizationForType(typ) {
return colDefault, transform.SameTree, nil
}
val, err := colDefault.Eval(ctx, nil)
if err != nil {
return colDefault, transform.SameTree, nil
}
colDefault.Expr = expression.NewLiteral(val, typ)
return colDefault, transform.NewTree, nil

newDefault, err := colDefault.WithChildren(expression.NewLiteral(val, typ))
if err != nil {
return nil, transform.SameTree, err
}
return newDefault, transform.NewTree, nil
}

// skipDefaultNormalizationForType returns true if the default value for the given type should not be normalized for
// serialization before being passed to the integrator for table creation
func skipDefaultNormalizationForType(typ sql.Type) bool {
// Extended types handle their own serialization concerns
if _, ok := typ.(types.ExtendedType); ok {
return true
}
return types.IsTime(typ) || types.IsTimespan(typ) || types.IsEnum(typ) || types.IsSet(typ) || types.IsJSON(typ)
}
Loading