refactor create procedure and call procedure #2833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into james/proc
… into james/proc
max-hoffman
approved these changes
Feb 7, 2025
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
The shape of the changes looks good, if all tests pass it seems like a good directional improvement even if it's still missing correctness edge cases.
|
|
||
| // limit validation | ||
| case *ast.Select: | ||
| if s.Limit != nil { |
Contributor
There was a problem hiding this comment.
the limit/offset in analyzer seems like it does a lot, was this for a specific test that regular analyzer loop doesn't catch?
Contributor
Author
There was a problem hiding this comment.
Yep, create procedure needs to check that the limit/offset value is actually a numeric.
added 2 commits
February 7, 2025 11:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors a ton of the stored procedure behavior to more closely match MySQL.
Changes:
plan.CallnodesPartially addresses: dolthub/dolt#8053