[no-release-notes] test for left join bug #2840
Conversation
| }, | ||
| tests: []JoinOpTests{ | ||
| { | ||
| Query: "select /*+ JOIN_ORDER(ab,xy) */ x from xy left join ab on x = a and z = 5 where a is null order by x ", |
There was a problem hiding this comment.
Kind of surprised this join hint does anything, isn't it ignored? Maybe add a comment
There was a problem hiding this comment.
for these tests join order does not appear to be respected, the hint and join code has a lot of change, i imagine it worked at some point, we should probably fix that
| "insert into ab values (0,1,0), (1,2,1), (2,3,2), (3,4,3);", | ||
| }, | ||
| }, | ||
| tests: []JoinOpTests{ |
There was a problem hiding this comment.
Because of the z=5 join condition, you're getting every row in the left table in the result set. You should have a variant where not every row in the left corner is included (because there is a match for at least one of the rows in the right-hand side of the join).
There was a problem hiding this comment.
added more tests
| }, | ||
| }, | ||
| { | ||
| name: "type conversion panic bug", |
There was a problem hiding this comment.
Should add a comment with details on what the error is here (comparing varchar to int literal)
No description provided.