Skip to content

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Feb 25, 2025

When creating the trigger scope, we copy over the columns and rewrite with the new and old scope, but we don't copy over their expressions as well. This PR fixes that.

fixes: dolthub/dolt#8886

Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jycor jycor merged commit e410216 into main Feb 25, 2025
8 checks passed
@jycor jycor deleted the james/trig1 branch February 25, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing old and new scopes in triggers for projections

3 participants