Added regexp_instr and regexp_substr #2863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reltuk
reviewed
Feb 28, 2025
Contributor
reltuk
left a comment
reltuk
left a comment
There was a problem hiding this comment.
Some comments. Generally looks reasonable. Some details to patch up I think.
Hydrocharged
force-pushed
the
daylon/regex-funcs
branch
from
7ff1682 to
ff2d313
Compare
reltuk
approved these changes
Mar 3, 2025
Contributor
reltuk
left a comment
reltuk
left a comment
There was a problem hiding this comment.
LGTM! Thanks for taking a pass on the feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the functions
regexp_instrandregexp_substr. This also references the new interface functions in:This is for the following issue: