more precision fixes for unix_timestamp
#2918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
reviewed
Mar 28, 2025
sql/expression/function/date.go
Outdated
|
|
||
| const MaxUnixTimeMicroSecs = 32536771199999999 | ||
|
|
||
| // noEval returns true if the expression contains an expression that cannot be evaluated without sql.Context or sql.Row. |
max-hoffman
approved these changes
Mar 28, 2025
sql/types/datetime.go
Outdated
Comment on lines
353
to
356
| if dtType, isDtType := otherType.(sql.DatetimeType); isDtType { | ||
| return t.baseType == dtType.Type() && t.precision == dtType.Precision() | ||
| } | ||
| return t.baseType == otherType.Type() |
Contributor
There was a problem hiding this comment.
maybe?
Suggested change
| if dtType, isDtType := otherType.(sql.DatetimeType); isDtType { | |
| return t.baseType == dtType.Type() && t.precision == dtType.Precision() | |
| } | |
| return t.baseType == otherType.Type() | |
| if dtType, isDtType := otherType.(sql.DatetimeType); isDtType { | |
| return t.precision == dtType.Precision() | |
| } | |
| return false |
nicktobey
pushed a commit
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
fixes: dolthub/dolt#9025