no implicit comits for temporary tables. #2954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
approved these changes
Apr 24, 2025
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Looks good!
Nice comments in the test – that was a big help in understanding the intent and expectations of the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we initially implemented implicit commits, we did not exclude temporary tables. This PR addresses that issue.
These queries no longer implicitly commit the ongoing transaction:
create temporary table tmp_tbl(...),insert into table tmp_tbl ...,drop temporary table tmp_tblHowever
drop table tmp_tblwill still cause an implicit commit even thoughtmp_tblis defined as a temporary table (not sure if this is intentional from MySQL side).Additionally,
alter table tmp_tbl ...will also cause an implicit commit, but we don't support altering temporary tables (issue).Fixes: dolthub/dolt#9149