Skip to content

Conversation

@zachmu
Copy link
Member

@zachmu zachmu commented Apr 29, 2025

This makes literal expression implement the sqlparser.Injectable interface so they can be used in Doltgres AST conversion.

Also exports fields so literals can be edited in place (required for how Doltgres processes these in a couple places).

This is an alternative to #2946.

@zachmu zachmu requested a review from max-hoffman April 29, 2025 00:46
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much easier

@zachmu zachmu merged commit ec78760 into main May 1, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants