fix prepare statements and user vars in stored procedures #2961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
May 1, 2025
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
the changes lgtm, looks like user vars did previously work and these are just tests?
| // todo(max): improve name resolution so we can cache post name-binding. | ||
| // this involves expression memoization, which currently screws up aggregation | ||
| // and order by aliases | ||
| prepStmt, _, err := e.Parser.ParseOneWithOptions(ctx, query, sqlMode.ParserOptions()) |
Contributor
There was a problem hiding this comment.
any gut instinct on whether the comment is outdated?
Contributor
Author
There was a problem hiding this comment.
User vars did not work previously in Stored Procedures, but they work better after the rewrite.
It seems like we do cache, so the TODO is outdated(?). Can delete.
added 2 commits
May 2, 2025 11:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for user variables within Stored Procedures.
Additionally, this PR has changes so that we don't double parse
PREPARE ... FROM ...statements, which also allows them to be used in the updated Stored Procedures call.fixes: dolthub/dolt#8911