Unwrap inputs to REGEXP_LIKE, REPLACE, and RPAD/LPAD functions. #2964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macneale4
approved these changes
May 1, 2025
Contributor
macneale4
left a comment
macneale4
left a comment
There was a problem hiding this comment.
Looks good. I'm not sure why those blocks are there, but you can ship it if you want them there for some reason I'm not seeing.
|
|
||
| if fromStr.(string) == "" { | ||
| return str, nil | ||
| { |
Contributor
There was a problem hiding this comment.
Why the additional block?
Contributor
Author
There was a problem hiding this comment.
The blocks are there so that I can redeclare fromStr et al as strings instead of interface{}. Without the block I'd need to pick new names for the unwrapped versions, which would be noisy.
| } | ||
|
|
||
| return padString(str.(string), length.(int64), padStr.(string), p.padType) | ||
| { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a couple more functions whose inputs aren't being unwrapped. If the inputs come from a column with a
TEXTtype, then they won't be converted to strings and the functions will fail. This PR fixes this by making sure that the inputs are converted.We missed this previously because although we have tests for these functions, none of them tested getting the inputs from TEXT columns of a table.