[no-release-notes] Rollforward "Unwrap inputs to REGEXP_LIKE, RPAD, LPAD, and REPLACE functions." #2968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macneale4
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR as #2964, which was accidentally merged despite breaking some tests.
From the original PR:
These are a couple more functions whose inputs aren't being unwrapped. If the inputs come from a column with a TEXT type, then they won't be converted to strings and the functions will fail. This PR fixes this by making sure that the inputs are converted.
We missed this previously because although we have tests for these functions, none of them tested getting the inputs from TEXT columns of a table.