From fa6d02df6eace940d1cc22cc71b0c9f5d1b39e19 Mon Sep 17 00:00:00 2001 From: Zach Musgrave Date: Wed, 28 May 2025 15:32:30 -0700 Subject: [PATCH] Revert "Merge pull request #2894 from dolthub/max/nil-proc-db" This reverts commit ce4535ec2da6600a552279a5abf46eb652b7eec0, reversing changes made to f38274720545e418e94e16b664302d96098d515e. --- enginetest/enginetests.go | 1 - sql/planbuilder/proc.go | 3 --- 2 files changed, 4 deletions(-) diff --git a/enginetest/enginetests.go b/enginetest/enginetests.go index 9a674f1a14..d6fca96fd9 100644 --- a/enginetest/enginetests.go +++ b/enginetest/enginetests.go @@ -4881,7 +4881,6 @@ func TestNoDatabaseSelected(t *testing.T, harness Harness) { AssertErrWithCtx(t, e, harness, ctx, "create table a (b int primary key)", nil, sql.ErrNoDatabaseSelected) AssertErrWithCtx(t, e, harness, ctx, "show tables", nil, sql.ErrNoDatabaseSelected) AssertErrWithCtx(t, e, harness, ctx, "show triggers", nil, sql.ErrNoDatabaseSelected) - AssertErrWithCtx(t, e, harness, ctx, "call non_existent_proc()", nil, sql.ErrNoDatabaseSelected) _, _, _, err := e.Query(ctx, "ROLLBACK") require.NoError(t, err) diff --git a/sql/planbuilder/proc.go b/sql/planbuilder/proc.go index 04625b5ff5..cbd844a543 100644 --- a/sql/planbuilder/proc.go +++ b/sql/planbuilder/proc.go @@ -304,9 +304,6 @@ func (b *Builder) buildCall(inScope *scope, c *ast.Call) (outScope *scope) { } else if b.ctx.GetCurrentDatabase() != "" { db = b.currentDb() } - if db == nil { - b.handleErr(sql.ErrNoDatabaseSelected.New()) - } var proc *plan.Procedure var innerQFlags *sql.QueryFlags