Skip to content

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented May 29, 2025

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

srabraham added a commit to burningmantech/ranger-ims-go that referenced this pull request May 30, 2025
the main thing needed was to set MaxOpenConns to 1 for the fake
DB, because it doesn't support parallel queries:
dolthub/go-mysql-server#1306 (comment)

the only thing still not working in the fake DB is striking/unstriking
of report entries, because of this issue I logged:
dolthub/dolt#9268
but a fix is incoming:
dolthub/go-mysql-server#3000
srabraham added a commit to burningmantech/ranger-ims-go that referenced this pull request May 30, 2025
the main thing needed was to set MaxOpenConns to 1 for the fake
DB, because it doesn't support parallel queries:
dolthub/go-mysql-server#1306 (comment)

the only thing still not working in the fake DB is striking/unstriking
of report entries, because of this issue I logged:
dolthub/dolt#9268
but a fix is incoming:
dolthub/go-mysql-server#3000
srabraham added a commit to burningmantech/ranger-ims-go that referenced this pull request May 30, 2025
the main thing needed was to set MaxOpenConns to 1 for the fake
DB, because it doesn't support parallel queries:
dolthub/go-mysql-server#1306 (comment)

the only thing still not working in the fake DB is striking/unstriking
of report entries, because of this issue I logged:
dolthub/dolt#9268
but a fix is incoming:
dolthub/go-mysql-server#3000
@jycor jycor merged commit ad826cd into main May 30, 2025
8 checks passed
@jycor jycor deleted the james/update_join branch May 30, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update with subselect in WHERE clause silently fails to update

3 participants