Add support for IS NULL expressions with records
#3004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
force-pushed
the
fulghum/tuple_is_null
branch
from
b4df373 to
6f1d56c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation in GMS for
IS NULLchecks if the value isNULLor not. For record and composite types in Postgres,IS NULLneeds to check if each value in the record or composite type isNULLto determine if the value isNULL. See dolthub/doltgresql#1520 for more details.This change creates a new shared type, named
TupleValue, in GMS that is used for record values (and eventually, composite type values). I also considered giving Doltgres it's own, customIsNullimplementation, but the analyzer does specific checks and optimizations when it looks for*expression.IsNullinstances, which would stop working correctly.