Skip to content

Conversation

@timsehn
Copy link
Contributor

@timsehn timsehn commented Jun 3, 2025

This is a proposed fix for Dolt issue: dolthub/dolt#8909

I'm not certain if we want to just add this field or replace connect time. I think this implementation is safer.

@timsehn timsehn requested a review from fulghum June 3, 2025 21:39
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like adding the new field, instead of replacing the connectTime field. People could probably also change their logger format to include the time, which is a good practice, and this would duplicate that, but could still be worth including.

Code changes looked fine, but Claude got pretty messy with the tests. 🤖

@timsehn timsehn merged commit 4f0d958 into main Jun 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants