Skip to content

Simplify implementation of hasSingleOutput #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

Simplify implementation of hasSingleOutput #3014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions sql/analyzer/apply_hash_in.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,13 @@ func applyHashIn(ctx *sql.Context, a *Analyzer, n sql.Node, scope *plan.Scope, s

// hasSingleOutput checks if an expression evaluates to a single output
func hasSingleOutput(e sql.Expression) bool {
return !transform.InspectExpr(e, func(expr sql.Expression) bool {
return transform.InspectExpr(e, func(expr sql.Expression) bool {
switch expr.(type) {
case expression.Tuple, *expression.Literal, *expression.GetField,
expression.Comparer, *expression.Convert, sql.FunctionExpression,
*expression.IsTrue, *expression.IsNull, expression.ArithmeticOp:
case *plan.Subquery:
return false
default:
return true
}
return false
})
}

Expand Down