Skip to content

Conversation

@elianddb
Copy link
Contributor

@elianddb elianddb commented Jun 9, 2025

Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Add a few simple engine tests in gms/enginetest/queries/queries.go in the QueryTests slice. Something like:

{
	Query:    "select ord(i) from mytable",
	Expected: []sql.Row{...},
},

These can be run from gms/enginetest/memory_engine_test.go function TestQueriesSimple()

@elianddb
Copy link
Contributor Author

@jycor I've completed the suggested changes, and added the test let me know if there anything else to do. Otherwise, I'll merge.

@elianddb elianddb merged commit 9688af8 into main Jun 11, 2025
8 checks passed
@elianddb elianddb linked an issue Jun 11, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support OCT() function

3 participants