[no-release-notes] Trace debugger for join planner, bug fix for Doltgres indexed joins #3289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing indexes for certain queries
angelamayxie
reviewed
Nov 5, 2025
angelamayxie
reviewed
Nov 5, 2025
| } | ||
|
|
||
| m.Tracer.Log("Starting cost-based optimization for groups %s", m) | ||
| if m.Tracer.TraceEnabled { |
Contributor
There was a problem hiding this comment.
is this check needed here?
angelamayxie
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new trace logging level to the Analyzer, which is only used in the join planning phase. Various new debug print methods are added to ExprGroup.
Adds an pseudo-extension point for SplitConjunction's use in join planning, which is necessary to properly detect the join conditions for use in indexes in Doltgres.
Finally, introduces several iterator methods for ExprGroup and related objects.