Wrap nullable hoisted filter in IsTrue #3302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes dolthub/dolt#10070
Filters that evaluate to null in an
EXISTSorINsubquery context should be treated the same as false. When hoisted out of the subquery, nullable filters need to be wrapped in anIsTrueexpression to ensure that they are still treated the same as false when they evaluate to null.Not doing so was causing a bug where rows were being dropped from
NOT EXISTSif the filter evaluated to null. Since the filter expression was evaluated to null, theNOTexpression wrapping it would evaluate to null as well. This caused the filter iterator to reject the row because it did not evaluate to true. Wrapping the filter expression withIsTrueensures that nulls are then evaluated to false, which will then evaluate to true withNOT.