go/sqltypes/arithmetic_test.go: PR feedback.

Author: reltuk

go/sqltypes/arithmetic_test.go

@@ -523,22 +523,20 @@ func TestNullsafeAdd(t *testing.T) {
 		v1:  NewInt64(-1),
 		v2:  NewUint64(2),
 		out: NewInt64(-9223372036854775808),
-	}, {
-		// Make sure underlying error is returned while converting.
-		v1:  NewFloat64(1),
-		v2:  NewFloat64(2),
-		out: NewInt64(3),
-	}}
-	if runtime.GOARCH != "amd64" {
 		// This test relies on float64 -> int64 conversion, where the float64 is larger than the maximum int64.
 		// According to the Golang spec:
 		//
 		// > In all non-constant conversions involving floating-point or complex values, if the result
 		// type cannot represent the value the conversion succeeds but the result value is implementation-dependent.
 		//
 		// And indeed, the test fails on arm64 but passes on amd64 because the computed conversion is different.
-		tcases[6].skip = true
-	}
+		skip: runtime.GOARCH != "amd64",
+	}, {
+		// Make sure underlying error is returned while converting.
+		v1:  NewFloat64(1),
+		v2:  NewFloat64(2),
+		out: NewInt64(3),
+	}}
 	for _, tcase := range tcases {
 		if tcase.skip {
 			t.SkipNow()