Enquote SQL identifiers (#77)

Author: nakamura-to

codegen/src/main/java/org/seasar/doma/gradle/codegen/dialect/CodeGenDialect.java

@@ -44,4 +44,12 @@ Map<String, String> getColumnCommentMap(
   String convertToDateLiteral(String value);
 
   String convertToTimestampLiteral(String value);
+
+  /**
+   * Enclose the name with quotation marks.
+   *
+   * @param name the name of a database object such as a table, a column, and so on
+   * @return the name that is enclosed with quotation marks
+   */
+  String applyQuote(String name);
 }

codegen/src/main/java/org/seasar/doma/gradle/codegen/dialect/Mssql2008CodeGenDialect.java

@@ -10,6 +10,12 @@
 
 public class Mssql2008CodeGenDialect extends StandardCodeGenDialect {
 
+  /** the quotation mark of the start */
+  protected static final char OPEN_QUOTE = '[';
+
+  /** the quotation mark of the end */
+  protected static final char CLOSE_QUOTE = ']';
+
   public Mssql2008CodeGenDialect() {
     classNameMap.put("datetime", LocalDateTime.class.getName());
     classNameMap.put("datetime2", LocalDateTime.class.getName());
@@ -64,4 +70,9 @@ public String getMappedPropertyClassName(ColumnMeta columnMeta) {
     }
     return super.getMappedPropertyClassName(columnMeta);
   }
+
+  @Override
+  public String applyQuote(String name) {
+    return OPEN_QUOTE + name + CLOSE_QUOTE;
+  }
 }

codegen/src/main/java/org/seasar/doma/gradle/codegen/dialect/MysqlCodeGenDialect.java

@@ -11,6 +11,12 @@
 
 public class MysqlCodeGenDialect extends StandardCodeGenDialect {
 
+  /** the quotation mark of the start */
+  protected static final char OPEN_QUOTE = '`';
+
+  /** the quotation mark of the end */
+  protected static final char CLOSE_QUOTE = '`';
+
   public MysqlCodeGenDialect() {
     classNameMap.put("bool", Boolean.class.getName());
     classNameMap.put("boolean", Boolean.class.getName());
@@ -81,4 +87,9 @@ public boolean supportsIdentity() {
   public boolean supportsSequence() {
     return true;
   }
+
+  @Override
+  public String applyQuote(String name) {
+    return OPEN_QUOTE + name + CLOSE_QUOTE;
+  }
 }

codegen/src/main/java/org/seasar/doma/gradle/codegen/dialect/StandardCodeGenDialect.java

@@ -25,6 +25,12 @@
 
 public class StandardCodeGenDialect implements CodeGenDialect {
 
+  /** the quotation mark of the start */
+  protected static final char OPEN_QUOTE = '"';
+
+  /** the quotation mark of the end */
+  protected static final char CLOSE_QUOTE = '"';
+
   protected final Map<String, String> classNameMap = new HashMap<String, String>();
 
   protected final Map<Integer, String> fallbackClassNameMap = new HashMap<Integer, String>();
@@ -124,8 +130,10 @@ public boolean isAutoIncrement(
     if (columnName == null) {
       throw new CodeGenNullPointerException("columnName");
     }
-    String fullTableName = TableUtil.getQualifiedTableName(catalogName, schemaName, tableName);
-    String sql = "select " + columnName + " from " + fullTableName + " where 1 = 0";
+    String fullTableName =
+        TableUtil.getEnquoteQualifiedTableName(
+            this::applyQuote, catalogName, schemaName, tableName);
+    String sql = "select " + applyQuote(columnName) + " from " + fullTableName + " where 1 = 0";
     PreparedStatement preparedStatement = connection.prepareStatement(sql);
     try {
       ResultSet resultSet = preparedStatement.executeQuery();
@@ -220,4 +228,9 @@ public String convertToTimestampLiteral(String value) {
     }
     return "'" + value + "'";
   }
+
+  @Override
+  public String applyQuote(String name) {
+    return OPEN_QUOTE + name + CLOSE_QUOTE;
+  }
 }

codegen/src/main/java/org/seasar/doma/gradle/codegen/util/TableUtil.java

@@ -1,5 +1,7 @@
 package org.seasar.doma.gradle.codegen.util;
 
+import java.util.function.Function;
+
 public final class TableUtil {
 
   public static String getQualifiedTableName(
@@ -13,4 +15,16 @@ public static String getQualifiedTableName(
     }
     return buf.append(tableName).toString();
   }
+
+  public static String getEnquoteQualifiedTableName(
+      Function<String, String> enquote, String catalogName, String schemaName, String tableName) {
+    StringBuilder buf = new StringBuilder();
+    if (catalogName != null && !catalogName.isEmpty()) {
+      buf.append(enquote.apply(catalogName)).append(".");
+    }
+    if (schemaName != null && !schemaName.isEmpty()) {
+      buf.append(enquote.apply(schemaName)).append(".");
+    }
+    return buf.append(enquote.apply(tableName)).toString();
+  }
 }

codegen/src/test/java/org/seasar/doma/gradle/codegen/util/TableUtilTest.java

@@ -2,15 +2,28 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
+import java.util.function.Function;
 import org.junit.jupiter.api.Test;
 
 public class TableUtilTest {
 
   @Test
-  public void test() throws Exception {
+  public void testGetQualifiedTableName() {
     assertEquals("aaa.bbb.ccc", TableUtil.getQualifiedTableName("aaa", "bbb", "ccc"));
     assertEquals("bbb.ccc", TableUtil.getQualifiedTableName(null, "bbb", "ccc"));
     assertEquals("aaa.ccc", TableUtil.getQualifiedTableName("aaa", null, "ccc"));
     assertEquals("ccc", TableUtil.getQualifiedTableName(null, null, "ccc"));
   }
+
+  @Test
+  public void testGetEnquoteQualifiedTableName() {
+    Function<String, String> enquote = name -> "[" + name + "]";
+    assertEquals(
+        "[aaa].[bbb].[ccc]", TableUtil.getEnquoteQualifiedTableName(enquote, "aaa", "bbb", "ccc"));
+    assertEquals(
+        "[bbb].[ccc]", TableUtil.getEnquoteQualifiedTableName(enquote, null, "bbb", "ccc"));
+    assertEquals(
+        "[aaa].[ccc]", TableUtil.getEnquoteQualifiedTableName(enquote, "aaa", null, "ccc"));
+    assertEquals("[ccc]", TableUtil.getEnquoteQualifiedTableName(enquote, null, null, "ccc"));
+  }
 }