Refactor compile module for better code organization #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract configuration logic into dedicated classes: - CompileConfigurator: Central configuration manager - JavaCompileConfigurator: Java-specific configuration - KotlinCompileConfigurator: Kotlin/KAPT-specific configuration - Remove unused PLUGIN_ID constant from CompilePlugin - Fix minor syntax issues (double semicolon, unnecessary null checks) - Update CLAUDE.md to reflect new class structure This refactoring improves separation of concerns and makes the code more maintainable without changing any functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
New Class Structure
CompilePlugin: Simplified to act as an entry point that delegates toCompileConfiguratorCompileConfigurator: Central configuration manager that coordinates Java and Kotlin configurationJavaCompileConfigurator: Handles Java-specific compilation configurationKotlinCompileConfigurator: Handles Kotlin/KAPT-specific compilation configurationCode Cleanup
PLUGIN_IDconstant fromCompilePluginJavaCompileConfiguratorObjects.requireNonNullcall in Groovy codespotlessApplyDocumentation
CLAUDE.mdto reflect the new class structureTest plan
./gradlew test)./gradlew build)./gradlew spotlessApply)🤖 Generated with Claude Code