Skip to content

Commit 0dcf1b6

Browse files
committed
Update the test cases to specify the actual action family name.
1 parent b291da9 commit 0dcf1b6

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

src/test/kotlin/org/domaframework/doma/intellij/action/dao/ConvertSqlAnnotationToFileActionTest.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,12 @@
1616
package org.domaframework.doma.intellij.action.dao
1717

1818
import com.intellij.openapi.fileEditor.FileEditorManager
19+
import org.domaframework.doma.intellij.bundle.MessageBundle
1920

2021
class ConvertSqlAnnotationToFileActionTest : ConvertSqlActionTest() {
2122
private val sqlConversionPackage = "sqltofile"
22-
private val convertActionName = "Convert to SQL file (set sqlFile=true)"
23-
private val convertFamilyName = "Convert @Sql annotation to SQL file"
23+
private val convertActionName = MessageBundle.message("convert.sql.annotation.to.file.text")
24+
private val convertFamilyName = MessageBundle.message("convert.sql.annotation.to.file.family")
2425

2526
fun testIntentionAvailableForSelectWithSqlAnnotation() {
2627
val daoName = "SelectWithSqlAnnotationDao"

src/test/kotlin/org/domaframework/doma/intellij/action/dao/ConvertSqlFileToAnnotationActionTest.kt

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@ package org.domaframework.doma.intellij.action.dao
1818
import com.intellij.openapi.fileEditor.FileDocumentManager
1919
import com.intellij.psi.PsiDocumentManager
2020
import org.domaframework.doma.intellij.action.sql.ConvertSqlFileToAnnotationFromSqlAction
21+
import org.domaframework.doma.intellij.bundle.MessageBundle
2122

2223
class ConvertSqlFileToAnnotationActionTest : ConvertSqlActionTest() {
2324
private val sqlToAnnotationPackage = "sqltoannotation"
24-
private val convertActionName = "Convert to @Sql annotation (set sqlFile=false)"
25-
private val convertFamilyName = "Convert SQL file to @Sql annotation"
25+
private val convertActionName = MessageBundle.message("convert.sql.file.to.annotation.from.sql.text")
26+
private val convertFamilyName = MessageBundle.message("convert.sql.file.to.annotation.from.sql.family")
2627

2728
fun testIntentionAvailableForSelectWithSqlFile() {
2829
val daoName = "SelectWithSqlFileDao"
@@ -102,7 +103,10 @@ class ConvertSqlFileToAnnotationActionTest : ConvertSqlActionTest() {
102103
val intentions = myFixture.availableIntentions
103104
val convertIntention = intentions.find { it is ConvertSqlFileToAnnotationFromSqlAction }
104105

105-
assertNull("$convertFamilyName intention should NOT be available when SQL file doesn't exist", convertIntention)
106+
assertNull(
107+
"$convertFamilyName intention should NOT be available when SQL file doesn't exist",
108+
convertIntention,
109+
)
106110
}
107111

108112
fun testSqlFormattingInAnnotation() {
@@ -114,7 +118,12 @@ class ConvertSqlFileToAnnotationActionTest : ConvertSqlActionTest() {
114118
fun testSelectWithSqlFileConvertAnnotation() {
115119
val daoName = "SelectWithSqlFileConvertAnnotationDao"
116120
val sqlFileName = "selectEmployee.sql"
117-
doConvertActionTest(daoName, sqlToAnnotationPackage, convertFamilyName, ConvertSqlFileToAnnotationFromDaoAction::class)
121+
doConvertActionTest(
122+
daoName,
123+
sqlToAnnotationPackage,
124+
convertFamilyName,
125+
ConvertSqlFileToAnnotationFromDaoAction::class,
126+
)
118127
// Test SQL File Removed
119128
val generatedSql = findSqlFile("$sqlToAnnotationPackage/$daoName/$sqlFileName")
120129
assertTrue("SQL File [$sqlFileName] should exists ", generatedSql == null)

0 commit comments

Comments
 (0)