Refactor function resolution logic and improve SQL validation reporting

Author: xterao

src/main/kotlin/org/domaframework/doma/intellij/common/sql/directive/collector/StaticBuildFunctionCollector.kt

@@ -21,11 +21,8 @@ import com.intellij.openapi.project.Project
 import com.intellij.psi.PsiMethod
 import com.intellij.psi.PsiModifier
 import org.domaframework.doma.intellij.common.helper.ExpressionFunctionsHelper
-import org.domaframework.doma.intellij.common.psi.PsiParentClass
 import org.domaframework.doma.intellij.extension.getJavaClazz
-import org.domaframework.doma.intellij.extension.psi.psiClassType
 import org.domaframework.doma.intellij.setting.state.DomaToolsCustomFunctionSettings
-import kotlin.collections.mutableSetOf
 
 class StaticBuildFunctionCollector(
     private val project: Project,
@@ -46,14 +43,12 @@ class StaticBuildFunctionCollector(
             if (expressionClazz != null &&
                 ExpressionFunctionsHelper.isInheritor(expressionClazz)
             ) {
-                val psiParent = PsiParentClass(expressionClazz.psiClassType)
-                psiParent.searchMethod("")?.let { methods ->
-                    functions.addAll(
-                        methods.filter {
-                            isPublicFunction(it)
-                        },
-                    )
-                }
+                val methods = expressionClazz.allMethods
+                functions.addAll(
+                    methods.filter {
+                        isPublicFunction(it)
+                    },
+                )
             }
         }
 

src/main/kotlin/org/domaframework/doma/intellij/common/sql/validator/result/ValidationInvalidFunctionCallResult.kt

@@ -23,7 +23,7 @@ import org.domaframework.doma.intellij.bundle.MessageBundle
 import org.domaframework.doma.intellij.common.psi.PsiParentClass
 
 /**
- * Non-existent package name or class
+ * Reports invalid function calls in SQL validation.
  */
 open class ValidationInvalidFunctionCallResult(
     override val identify: PsiElement,

src/main/kotlin/org/domaframework/doma/intellij/formatter/SqlPostProcessor.kt

@@ -60,10 +60,16 @@ class SqlPostProcessor : PostFormatProcessor {
         }
         return TextRange(0, finalText.length)
     }
+}
 
-    private fun isEnableFormat(project: Project): Boolean {
-        val setting = DomaToolsFormatEnableSettings.getInstance(project)
-        val isEnableFormat = setting.state.isEnableSqlFormat
-        return isEnableFormat
-    }
+/**
+ * Checks if SQL formatting is enabled in the project settings.
+ *
+ * @param project The project to check.
+ * @return `true` if SQL formatting is enabled, `false` otherwise.
+ */
+fun isEnableFormat(project: Project): Boolean {
+    val setting = DomaToolsFormatEnableSettings.getInstance(project)
+    val isEnableFormat = setting.state.isEnableSqlFormat
+    return isEnableFormat
 }

src/main/kotlin/org/domaframework/doma/intellij/inspection/sql/processor/InspectionFunctionCallVisitorProcessor.kt

@@ -37,12 +37,14 @@ class InspectionFunctionCallVisitorProcessor(
         val customFunctionClassNames = expressionFunctionSetting.state.customFunctionClassNames
 
         var methods: Array<out PsiMethod?> = emptyArray()
-        customFunctionClassNames.takeWhile { clazz ->
+        for (clazz in customFunctionClassNames) {
             val expressionClazz = project.getJavaClazz(clazz)
             if (expressionClazz != null && expressionHelper.isInheritor(expressionClazz)) {
                 methods = expressionClazz.findMethodsByName(functionName.text, true)
+                if (methods.isNotEmpty()) {
+                    break
+                }
             }
-            methods.isEmpty()
         }
 
         if (methods.isEmpty()) {