Refactor inspection error messages for DAO and SQL validations

xterao · xterao · commit 58a7bc0155f4 · 2025-05-14T18:21:34.000+09:00
diff --git a/src/main/kotlin/org/domaframework/doma/intellij/common/sql/validator/result/ValidationDaoParamResult.kt b/src/main/kotlin/org/domaframework/doma/intellij/common/sql/validator/result/ValidationDaoParamResult.kt
@@ -41,7 +41,7 @@ open class ValidationDaoParamResult(
         holder.registerProblem(
             identify,
             MessageBundle.message(
-                "inspector.invalid.dao.parameter",
+                "inspection.invalid.dao.parameter",
                 daoName,
                 identify.text ?: "",
             ),
diff --git a/src/main/kotlin/org/domaframework/doma/intellij/common/sql/validator/result/ValidationPropertyResult.kt b/src/main/kotlin/org/domaframework/doma/intellij/common/sql/validator/result/ValidationPropertyResult.kt
@@ -46,7 +46,7 @@ class ValidationPropertyResult(
         holder.registerProblem(
             identify,
             MessageBundle.message(
-                "inspector.invalid.class.property",
+                "inspection.invalid.sql.property",
                 parentName,
                 identify.text ?: "",
             ),
diff --git a/src/main/kotlin/org/domaframework/doma/intellij/inspection/dao/inspector/DaoMethodVariableInspector.kt b/src/main/kotlin/org/domaframework/doma/intellij/inspection/dao/inspector/DaoMethodVariableInspector.kt
@@ -93,7 +93,7 @@ class DaoMethodVariableInspector : AbstractBaseJavaLocalInspectionTool() {
                                 MessageBundle.message("inspection.invalid.dao.duplicate")
                             } else {
                                 MessageBundle.message(
-                                    "inspection.dao.method.variable.error",
+                                    "inspection.invalid.dao.paramUse",
                                     param.name,
                                 )
                             }
diff --git a/src/main/kotlin/org/domaframework/doma/intellij/inspection/dao/inspector/SqlFileExistInspector.kt b/src/main/kotlin/org/domaframework/doma/intellij/inspection/dao/inspector/SqlFileExistInspector.kt
@@ -68,7 +68,7 @@ class SqlFileExistInspector : AbstractBaseJavaLocalInspectionTool() {
         if (psiDaoMethod.sqlFile == null) {
             problemHolder.registerProblem(
                 identifier,
-                MessageBundle.message("inspection.sql.not.exist.error"),
+                MessageBundle.message("inspection.invalid.dao.notExistSql"),
                 ProblemHighlightType.ERROR,
                 GenerateSQLFileQuickFixFactory.createSql(psiDaoMethod),
             )

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ class DaoMethodVariableInspector : AbstractBaseJavaLocalInspectionTool() {`
`93`	`93`	`MessageBundle.message("inspection.invalid.dao.duplicate")`
`94`	`94`	`} else {`
`95`	`95`	`MessageBundle.message(`
`96`		`- "inspection.dao.method.variable.error",`
	`96`	`+ "inspection.invalid.dao.paramUse",`
`97`	`97`	`param.name,`
`98`	`98`	`)`
`99`	`99`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ class SqlFileExistInspector : AbstractBaseJavaLocalInspectionTool() {`
`68`	`68`	`if (psiDaoMethod.sqlFile == null) {`
`69`	`69`	`problemHolder.registerProblem(`
`70`	`70`	`identifier,`
`71`		`- MessageBundle.message("inspection.sql.not.exist.error"),`
	`71`	`+ MessageBundle.message("inspection.invalid.dao.notExistSql"),`
`72`	`72`	`ProblemHighlightType.ERROR,`
`73`	`73`	`GenerateSQLFileQuickFixFactory.createSql(psiDaoMethod),`
`74`	`74`	`)`