Skip to content

Commit 84fc506

Browse files
committed
Add Char type to the condition as a literal
1 parent 1cf1249 commit 84fc506

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

src/main/kotlin/org/domaframework/doma/intellij/inspection/sql/inspector/SqlBindVariableValidInspector.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,7 @@ class SqlBindVariableValidInspector : LocalInspectionTool() {
256256
private fun isLiteralOrStatic(targetElement: PsiElement): Boolean =
257257
(
258258
targetElement.firstChild?.elementType == SqlTypes.EL_STRING ||
259+
targetElement.firstChild?.elementType == SqlTypes.EL_CHAR ||
259260
targetElement.firstChild?.elementType == SqlTypes.EL_NUMBER ||
260261
targetElement.firstChild?.elementType == SqlTypes.EL_NULL ||
261262
targetElement.firstChild?.elementType == SqlTypes.EL_BOOLEAN ||

src/test/testData/src/main/resources/META-INF/doma/example/dao/EmployeeSummaryDao/bindVariableForEntityAndNonEntityParentClass.sql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ INSERT INTO employee_project (employee_name, department, project)
77
FROM
88
employee e1
99
JOIN user u1 ON e1.employee_id = u1.user_id
10+
AND e1.user_tag = /*# 't' */'a'
11+
AND e1.user_dept = /*# "development" */'dev'
1012
-- Access to parent private field
1113
WHERE u1.user_name = /* employee.userName.toLowerCase() */'name'
1214
-- Access to non-existent parent field

0 commit comments

Comments
 (0)