Add factory parameter and return type test DAOs with validation errors

Author: xterao

src/test/kotlin/org/domaframework/doma/intellij/inspection/dao/AnnotationParamTypeCheckInspectionTest.kt

@@ -24,13 +24,14 @@ import org.domaframework.doma.intellij.inspection.dao.inspector.DaoMethodParamTy
 class AnnotationParamTypeCheckInspectionTest : DomaSqlTest() {
     private val testDaoNames =
         listOf(
+            "SelectParamTestDao",
             "InsertUpdateDeleteParamTestDao",
             "BatchInsertUpdateDeleteParamTestDao",
             "MultiInsertParamTestDao",
             "ProcedureParamTestDao",
             "ScriptParamTestDao",
             "SqlProcessorParamTestDao",
-            "SelectParamTestDao",
+            "FactoryParamTestDao",
         )
     private val daoPackage = "inspection/paramtype"
 
@@ -80,4 +81,9 @@ class AnnotationParamTypeCheckInspectionTest : DomaSqlTest() {
         val dao = findDaoClass("$daoPackage.SqlProcessorParamTestDao")
         myFixture.testHighlighting(false, false, false, dao.containingFile.virtualFile)
     }
+
+    fun testFactoryParam() {
+        val dao = findDaoClass("$daoPackage.FactoryParamTestDao")
+        myFixture.testHighlighting(false, false, false, dao.containingFile.virtualFile)
+    }
 }

src/test/kotlin/org/domaframework/doma/intellij/inspection/dao/AnnotationReturnTypeCheckInspectionTest.kt

@@ -31,6 +31,7 @@ class AnnotationReturnTypeCheckInspectionTest : DomaSqlTest() {
             "SqlProcessorReturnTypeTestDao",
             "ProcedureReturnTypeTestDao",
             "FunctionReturnTypeTestDao",
+            "FactoryReturnTypeTestDao",
         )
     private val daoPackage = "inspection/returntype"
 
@@ -52,33 +53,38 @@ class AnnotationReturnTypeCheckInspectionTest : DomaSqlTest() {
         myFixture.testHighlighting(false, false, false, dao.containingFile.virtualFile)
     }
 
-    fun testUpdateAnnotationReturnTypeCheckProcessor() {
+    fun testUpdateReturnTypeCheckProcessor() {
         val dao = findDaoClass("$daoPackage.UpdateReturnTypeTestDao")
         myFixture.testHighlighting(false, false, false, dao.containingFile.virtualFile)
     }
 
-    fun testBatchAnnotationReturnTypeCheckProcessor() {
+    fun testBatchReturnTypeCheckProcessor() {
         val dao = findDaoClass("$daoPackage.BatchReturnTypeTestDao")
         myFixture.testHighlighting(false, false, false, dao.containingFile.virtualFile)
     }
 
-    fun testMultiInsertAnnotationReturnTypeCheckProcessor() {
+    fun testMultiInsertReturnTypeCheckProcessor() {
         val dao = findDaoClass("$daoPackage.MultiInsertReturnTypeTestDao")
         myFixture.testHighlighting(false, false, false, dao.containingFile.virtualFile)
     }
 
-    fun testSqlProcessorAnnotationReturnTypeCheckProcessor() {
+    fun testSqlProcessorReturnTypeCheckProcessor() {
         val dao = findDaoClass("$daoPackage.SqlProcessorReturnTypeTestDao")
         myFixture.testHighlighting(false, false, false, dao.containingFile.virtualFile)
     }
 
-    fun testProcedureAnnotationReturnTypeCheckProcessor() {
+    fun testProcedureReturnTypeCheckProcessor() {
         val dao = findDaoClass("$daoPackage.ProcedureReturnTypeTestDao")
         myFixture.testHighlighting(false, false, false, dao.containingFile.virtualFile)
     }
 
-    fun testFunctionAnnotationReturnTypeCheckProcessor() {
+    fun testFunctionReturnTypeCheckProcessor() {
         val dao = findDaoClass("$daoPackage.FunctionReturnTypeTestDao")
         myFixture.testHighlighting(false, false, false, dao.containingFile.virtualFile)
     }
+
+    fun testFactoryReturnTypeCheckProcessor() {
+        val dao = findDaoClass("$daoPackage.FactoryReturnTypeTestDao")
+        myFixture.testHighlighting(false, false, false, dao.containingFile.virtualFile)
+    }
 }

src/test/testData/src/main/java/doma/example/dao/inspection/paramtype/FactoryParamTestDao.java

@@ -0,0 +1,45 @@
+package doma.example.dao.inspection.paramtype;
+
+import org.seasar.doma.*;
+import java.sql.*;
+import java.util.List;
+
+@Dao
+public interface FactoryParamTestDao {
+
+  @ArrayFactory(typeName = "integer")
+  Array createIntegerArray(Integer[] elements);
+
+  @ArrayFactory(typeName = "integer")
+  Array <error descr="The number of parameters must be one">create</error>();
+
+  @ArrayFactory(typeName = "text")
+  Array createString2DArray(String[][] elements);
+
+  @ArrayFactory(typeName = "text")
+  Array createStringList(List<String> <error descr="The parameter type must be an array type">elements</error>);
+
+  @BlobFactory
+  Blob createBlob();
+
+  @BlobFactory
+  Blob <error descr="The number of parameters must be zero">createBlobWithParam</error>(Integer id);
+
+  @ClobFactory
+  Clob createClob();
+
+  @ClobFactory
+  Clob <error descr="The number of parameters must be zero">createClobWithParam</error>(Integer id);
+
+  @NClobFactory
+  NClob createNClob();
+
+  @NClobFactory
+  NClob <error descr="The number of parameters must be zero">createNClobWithParam</error>(Integer id);
+
+  @SQLXMLFactory
+  SQLXML createSQLXML();
+
+  @SQLXMLFactory
+  SQLXML <error descr="The number of parameters must be zero">createSQLXMLWithParam</error>(Integer id);
+}

src/test/testData/src/main/java/doma/example/dao/inspection/paramtype/InsertUpdateDeleteParamTestDao.java

@@ -14,7 +14,7 @@ public interface InsertUpdateDeleteParamTestDao {
     int insertEntity(Packet packet);
 
     @Insert
-    int insertPrimitive(Integer <error descr="The parameter type must be an entity class">id</error>);
+    int insertPrimitive(Integer <error descr="The parameter type must be an entity">id</error>);
 
     @Update
     int <error descr="The number of parameters must be one">updateNoParams</error>();

src/test/testData/src/main/java/doma/example/dao/inspection/returntype/FactoryReturnTypeTestDao.java

@@ -0,0 +1,42 @@
+package doma.example.dao.inspection.returntype;
+
+import org.seasar.doma.*;
+import java.sql.*;
+import java.util.List;
+
+@Dao
+public interface FactoryReturnTypeTestDao {
+
+  @ArrayFactory(typeName = "integer")
+  Array createIntegerArray(Integer[] elements);
+
+  @ArrayFactory(typeName = "text")
+  Array createString2DArray(String[][] elements);
+
+  @ArrayFactory(typeName = "text")
+  List<String> <error descr="The return type must be \"java.sql.Array\"">createStringList</error>(Integer[] elements);
+
+  @BlobFactory
+  Blob createBlob();
+
+  @BlobFactory
+  Integer <error descr="The return type must be \"java.sql.Blob\"">createBlobWithInteger</error>();
+
+  @ClobFactory
+  Clob createClob();
+
+  @ClobFactory
+  Integer <error descr="The return type must be \"java.sql.Clob\"">createClobWithInteger</error>();
+
+  @NClobFactory
+  NClob createNClob();
+
+  @NClobFactory
+  Integer <error descr="The return type must be \"java.sql.NClob\"">createNClobWithInteger</error>();
+
+  @SQLXMLFactory
+  SQLXML createSQLXML();
+
+  @SQLXMLFactory
+  Integer <error descr="The return type must be \"java.sql.SQLXML\"">createSQLXMLWithInteger</error>();
+}