Fixed a suggestion from Qodana

Author: xterao

src/main/kotlin/org/domaframework/doma/intellij/action/sql/JumpToDeclarationFromSqlAction.kt

@@ -101,8 +101,8 @@ class JumpToDeclarationFromSqlAction : AnAction() {
 
     private fun countLeadingDoubleQuotes(s: String): Int {
         var count = 0
-        for (i in 0..<s.length) {
-            if (s[i] == '"') {
+        for (char in s) {
+            if (char == '"') {
                 count++
             } else {
                 break

src/main/kotlin/org/domaframework/doma/intellij/inspection/sql/inspector/SqlBindVariableValidInspector.kt

@@ -93,14 +93,12 @@ class SqlBindVariableValidInspector : LocalInspectionTool() {
         isOnTheFly: Boolean,
     ): SqlVisitor = sqlVisitor(holder)
 
-    fun sqlVisitor(holder: ProblemsHolder): SqlVisitor {
+    private fun sqlVisitor(holder: ProblemsHolder): SqlVisitor {
         return object : SqlVisitor() {
             override fun visitElement(o: PsiElement) {
-                var file = o.containingFile ?: return
+                val file = o.containingFile ?: return
                 if (isJavaOrKotlinFileType(file) && o is PsiLiteralExpression) {
-                    val injectionFile = initInjectionElement(file, o.project, o)
-                    if (injectionFile == null) return
-
+                    val injectionFile = initInjectionElement(file, o.project, o) ?: return
                     injectionFile.accept(this)
                     super.visitElement(o)
                 }
@@ -132,14 +130,14 @@ class SqlBindVariableValidInspector : LocalInspectionTool() {
 
             override fun visitElStaticFieldAccessExpr(o: SqlElStaticFieldAccessExpr) {
                 super.visitElStaticFieldAccessExpr(o)
-                var targetElement = o
+                val targetElement = o
                 checkStaticFieldAndMethodAccess(targetElement, holder)
             }
 
             override fun visitElFieldAccessExpr(o: SqlElFieldAccessExpr) {
                 super.visitElFieldAccessExpr(o)
-                var file = o.containingFile ?: return
-                var targetElement = o
+                val file = o.containingFile ?: return
+                val targetElement = o
 
                 // Get element inside block comment
                 val blockElement =
@@ -162,8 +160,8 @@ class SqlBindVariableValidInspector : LocalInspectionTool() {
 
             override fun visitElPrimaryExpr(o: SqlElPrimaryExpr) {
                 super.visitElPrimaryExpr(o)
-                var file = o.containingFile ?: return
-                var targetElement = o
+                val file = o.containingFile ?: return
+                val targetElement = o
                 val project = o.project
 
                 // Exclude fixed Literal