Code completion and code inspection for static property call package class names #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xterao
changed the title
xterao
force-pushed
the
feature/completion-static-class-package
branch
from
20008f7 to
a50237e
Compare
xterao
force-pushed
the
feature/completion-static-class-package
branch
from
a50237e to
1bf5898
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements code completion and inspection for static property call package class names. It introduces new collectors for static properties, class package suggestions, and build functions, refactoring existing retrievals of Java classes to use project-based extensions.
- Added new project extension for retrieving Java classes.
- Implemented new collectors: StaticPropertyCollector, StaticClassPackageCollector, and StaticBuildFunctionCollector.
- Refactored static directive handling to use the new collectors.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/org/domaframework/doma/intellij/extension/ProjectExtensions.kt | Adds a new getJavaClazz function to retrieve PsiClass based on a fully qualified name. |
| src/main/kotlin/org/domaframework/doma/intellij/contributor/sql/provider/SqlParameterCompletionProvider.kt | Updates usage of getJavaClazz to use the project extension. |
| src/main/kotlin/org/domaframework/doma/intellij/common/sql/directive/collector/StaticPropertyCollector.kt | Implements a collector for static property completion suggestions. |
| src/main/kotlin/org/domaframework/doma/intellij/common/sql/directive/collector/StaticDirectiveHandlerCollector.kt | Adds an abstract base for static directive handler collectors. |
| src/main/kotlin/org/domaframework/doma/intellij/common/sql/directive/collector/StaticClassPackageCollector.kt | Introduces package collection via package and file lookups for completion suggestions. |
| src/main/kotlin/org/domaframework/doma/intellij/common/sql/directive/collector/StaticBuildFunctionCollector.kt | Implements built-in functions collector for SQL directives. |
| src/main/kotlin/org/domaframework/doma/intellij/common/sql/directive/StaticDirectiveHandlerData.kt | Defines data structures for static directive completions. |
| src/main/kotlin/org/domaframework/doma/intellij/common/sql/directive/StaticDirectiveHandler.kt | Refactors static directive handling to use the new collectors. |
| src/main/kotlin/org/domaframework/doma/intellij/common/psi/PsiStaticElement.kt | Updates getRefClazz to use the project-based getJavaClazz. |
| src/main/kotlin/org/domaframework/doma/intellij/common/FileTypeCheck.kt | Adds a helper function for checking if a file is a Java or Kotlin file. |
Comments suppressed due to low confidence (2)
src/main/kotlin/org/domaframework/doma/intellij/common/sql/directive/collector/StaticClassPackageCollector.kt:67
- Consider using an equality check (==) instead of contains when matching package names if an exact match is intended, to avoid unintended fuzzy matching.
subPackagesParent = parentPackages?.find { it?.name?.contains(pkg) == true }
src/main/kotlin/org/domaframework/doma/intellij/common/sql/directive/collector/StaticBuildFunctionCollector.kt:65
- [nitpick] Multiple DomaFunction instances are defined with the same name 'roundDownTimePart' but different type information. Consider differentiating the function names or adding documentation to clarify their intended usage.
DomaFunction("roundDownTimePart", getJavaLangString(), listOf(getPsiTypeByClassName("java.lang.CharSequence"), getPsiTypeByClassName("java.lang.Char")))
74320e9 to
44b293d
Compare
…erty calls, and test cases for the Inspect feature.
…for static property calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports code completion, code inspection for the class package and class name where the staticProperty is called.