Completion for directive items #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances code completion by including element names defined in for directives along with _has_next and _index suggestions.
- Added a new test SQL file and corresponding DAO method for directive item completion.
- Updated Kotlin tests to verify the new completion suggestions.
- Modified the SQL Parameter Completion Provider to integrate for directive items into the suggestions.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/test/testData/src/main/resources/META-INF/doma/example/dao/SqlCompleteTestDao/completeForDirectiveItem.sql | Added SQL test file for for directive code completion. |
| src/test/testData/src/main/java/doma/example/dao/SqlCompleteTestDao.java | Introduced a new DAO method to test directive item completion. |
| src/test/kotlin/org/domaframework/doma/intellij/complate/sql/SqlCompleteTest.kt | Updated test cases to include the new directive item completion file and expected suggestions. |
| src/main/kotlin/org/domaframework/doma/intellij/contributor/sql/provider/SqlParameterCompletionProvider.kt | Revised methods to include for directive completions based on PSI element position. |
...n/org/domaframework/doma/intellij/contributor/sql/provider/SqlParameterCompletionProvider.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add element names defined by the for directive to code-completion suggestions.
When performing code completion at the top level of a bind variable, include the directive’s element names as well as _has_next and _index in the suggestions.