Fix error on code completion for SQL file with unrecognized DAO method #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a code completion error in SQL files that occurs when no corresponding DAO method is recognized. The fix prevents an IndexOutOfBoundsException by adding null-safety checks and removing a precondition that was too restrictive.
- Removed debug print statement from test file
- Added null-safety checks in SqlParameterCompletionProvider to handle cases where DAO method is not found
- Modified early return condition to handle empty element lists regardless of DAO method presence
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SqlSpecificParamTypeCompleteTest.kt | Removed debug print statement |
| SqlParameterCompletionProvider.kt | Added null-safety checks and modified early return logic to prevent errors when DAO method is not found |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
...n/org/domaframework/doma/intellij/contributor/sql/provider/SqlParameterCompletionProvider.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes an issue where invoking code completion on an SQL file that does not recognize the corresponding DAO method results in an error. The error occurs when the system attempts to retrieve the first element from an empty list during the suggestion of the top binding variable.
Bug Description
Changes
SqlParameterCompletionProviderto prevent error scenarios during code completion.Expected Behavior