Enable SQL Annotation Conversion Action from DAO Methods and Control SQL File Opening #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 11, 2025
xterao
deleted the
feature/sql-annotation-sqlfile-generation-action-per-class
branch
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables bi-directional SQL annotation conversion by allowing the conversion action to be triggered from DAO methods in Java/Kotlin files in addition to SQL files, and prevents automatic opening of generated SQL files to improve workflow efficiency.
- Extends SQL file to annotation conversion to work from Java/Kotlin DAO methods
- Adds Java language support for the ConvertSqlFileToAnnotationAction intention
- Modifies SQL file generation to prevent automatic opening of created files
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| plugin.xml | Registers ConvertSqlFileToAnnotationAction for Java language |
| ConvertSqlFileToAnnotationAction.kt | Adds support for triggering conversion from Java/Kotlin DAO methods |
| ConvertSqlAnnotationToFileAction.kt | Refactors to use shared helper methods and improves condition checking |
| SqlAnnotationConverter.kt | Moves supported types to companion object and adds file opening control |
| PsiDaoMethod.kt | Adds optional parameter to control file opening after SQL generation |
| ConvertSqlActionTest.kt | New base test class with shared test utilities |
| ConvertSqlFileToAnnotationActionTest.kt | Refactored to use base class and improved test assertions |
| ConvertSqlAnnotationToFileActionTest.kt | Refactored to use base class and updated file opening expectations |
| DaoClass.kt | Uses DomaClassName enum for consistency |
| DomaClassName.kt | Adds DAO class name constant |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/kotlin/org/domaframework/doma/intellij/action/dao/ConvertSqlFileToAnnotationAction.kt
Show resolved
Hide resolved
|
|
||
| val daoClass = findDaoClass("$sqlConversionPackage.$daoName") | ||
| myFixture.configureFromExistingVirtualFile(daoClass.containingFile.virtualFile) | ||
| println("convertActionName: $convertActionName") |
There was a problem hiding this comment.
Debug print statement should be removed from production test code. Use proper logging or remove this line entirely.
Suggested change
| println("convertActionName: $convertActionName") |
src/main/kotlin/org/domaframework/doma/intellij/action/dao/ConvertSqlAnnotationToFileAction.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the following changes:
These changes allow bi-directional conversion between SQL files and annotations directly from DAO methods, improving usability and workflow efficiency.