Fix: Annotation Option Checks Respect Entity Inheritance #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for property checks
…le entity annotations
…ips and PsiClass member access
…es from non-Entity parent classes as errors.
…rectly in the error message.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes annotation option validation in DAO parameters to properly respect Entity inheritance. The fix addresses an issue where properties defined in parent Entity classes were incorrectly flagged as errors when specified in include/exclude annotation options.
- Updated validation logic to use
allFieldsinstead offieldsto access inherited properties - Added filtering to only consider properties from Entity or Embeddable classes as valid options
- Enhanced test coverage with inheritance hierarchy test cases
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| DaoAnnotationOptionParameterCheckProcessor.kt | Core validation logic updated to handle inheritance and filter by Entity/Embeddable types |
| TypeUtil.kt | Minor cleanup removing redundant boolean comparison |
| PsiPatternUtil.kt | Variable declaration optimization |
| CLAUDE.md | Added guidance on using allFields/allMethods for inheritance support |
| .claude/guidelines/TEST_CASE_GUIDELINE.md | Enhanced test guidelines for Entity inheritance scenarios |
| Test entities | Added comprehensive Entity inheritance hierarchy test cases |
| Test DAOs | Added validation test cases for inherited properties |
| AnnotationOptionParameterInspectionTest.kt | New test class structure for manual validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../doma/intellij/inspection/dao/processor/option/DaoAnnotationOptionParameterCheckProcessor.kt
Outdated
Show resolved
Hide resolved
.../doma/intellij/inspection/dao/processor/option/DaoAnnotationOptionParameterCheckProcessor.kt
Show resolved
Hide resolved
xterao
deleted the
fix/annotation-option-check-when-using-a-parent-property
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When specifying properties in the
include/excludeannotation options for a DAO parameter’s Entity class, properties defined in a parent class were incorrectly highlighted as errors.Relation
#453
Solution
allFields, allowing retrieval of properties defined in parent classes.Impact
This fix ensures that annotation option checks properly follow Entity inheritance, preventing false error highlights and improving accuracy when working with inherited properties.