Support DuplicateKeyType for multi-row insert in SQL Server

Author: nakamura-to

doma-core/src/main/java/org/seasar/doma/jdbc/dialect/MssqlUpsertAssembler.java

@@ -7,6 +7,8 @@
 import org.seasar.doma.jdbc.query.DuplicateKeyType;
 import org.seasar.doma.jdbc.query.QueryOperand;
 import org.seasar.doma.jdbc.query.QueryOperandPair;
+import org.seasar.doma.jdbc.query.QueryOperandPairList;
+import org.seasar.doma.jdbc.query.QueryRows;
 import org.seasar.doma.jdbc.query.UpsertAssembler;
 import org.seasar.doma.jdbc.query.UpsertAssemblerContext;
 import org.seasar.doma.jdbc.query.UpsertAssemblerSupport;
@@ -17,7 +19,7 @@ public class MssqlUpsertAssembler implements UpsertAssembler {
   private final DuplicateKeyType duplicateKeyType;
   private final UpsertAssemblerSupport upsertAssemblerSupport;
   private final List<? extends EntityPropertyType<?, ?>> keys;
-  private final List<QueryOperandPair> insertValues;
+  private final QueryRows insertValues;
   private final List<QueryOperandPair> setValues;
   private final QueryOperand.Visitor queryOperandVisitor = new QueryOperandVisitor();
 
@@ -26,19 +28,16 @@ public MssqlUpsertAssembler(UpsertAssemblerContext context) {
     this.entityType = context.entityType;
     this.duplicateKeyType = context.duplicateKeyType;
     this.keys = context.keys;
-    this.insertValues = context.insertValues.first().getPairs();
+    this.insertValues = context.insertValues;
     this.setValues = context.setValues.getPairs();
     this.upsertAssemblerSupport = new UpsertAssemblerSupport(context.naming, context.dialect);
-    if (context.insertValues.getRows().size() > 1) {
-      throw new UnsupportedOperationException();
-    }
   }
 
   @Override
   public void assemble() {
     buf.appendSql("merge into ");
     tableNameAndAlias(entityType);
-    buf.appendSql(" using (");
+    buf.appendSql(" using ");
     excludeQuery();
     buf.appendSql(" on ");
     for (EntityPropertyType<?, ?> key : keys) {
@@ -49,13 +48,13 @@ public void assemble() {
     }
     buf.cutBackSql(5);
     buf.appendSql(" when not matched then insert (");
-    for (QueryOperandPair pair : insertValues) {
+    for (QueryOperandPair pair : insertValues.first().getPairs()) {
       column(pair.getLeft().getEntityPropertyType());
       buf.appendSql(", ");
     }
     buf.cutBackSql(2);
     buf.appendSql(") values (");
-    for (QueryOperandPair pair : insertValues) {
+    for (QueryOperandPair pair : insertValues.first().getPairs()) {
       excludeColumn(pair.getLeft().getEntityPropertyType());
       buf.appendSql(", ");
     }
@@ -75,16 +74,21 @@ public void assemble() {
   }
 
   private void excludeQuery() {
-    buf.appendSql("values (");
-    for (QueryOperandPair pair : insertValues) {
-      pair.getRight().accept(queryOperandVisitor);
-      buf.appendSql(", ");
+    buf.appendSql("(values ");
+    for (QueryOperandPairList row : insertValues.getRows()) {
+      buf.appendSql("(");
+      for (QueryOperandPair pair : row.getPairs()) {
+        pair.getRight().accept(queryOperandVisitor);
+        buf.appendSql(", ");
+      }
+      buf.cutBackSql(2);
+      buf.appendSql("), ");
     }
     buf.cutBackSql(2);
-    buf.appendSql(")) as ");
+    buf.appendSql(") as ");
     excludeAlias();
     buf.appendSql(" (");
-    for (QueryOperandPair pair : insertValues) {
+    for (QueryOperandPair pair : insertValues.first().getPairs()) {
       column(pair.getLeft().getEntityPropertyType());
       buf.appendSql(", ");
     }

integration-test-java/src/test/java/org/seasar/doma/it/auto/AutoMultiInsertTest.java

@@ -414,7 +414,7 @@ public void whenListIsEmpty(Config config) throws Exception {
   }
 
   @Test
-  @Run(unless = {Dbms.SQLSERVER, Dbms.ORACLE})
+  @Run(unless = {Dbms.ORACLE})
   public void insert_DuplicateKeyType_UPDATE(Config config) throws Exception {
     DeptDao dao = new DeptDaoImpl(config);
     Dept dept1 = new Dept(new Identity<>(5), 50, "PLANNING", new Location<>("TOKYO"), null);
@@ -456,7 +456,7 @@ public void insert_DuplicateKeyType_UPDATE(Config config) throws Exception {
   }
 
   @Test
-  @Run(unless = {Dbms.SQLSERVER, Dbms.ORACLE})
+  @Run(unless = {Dbms.ORACLE})
   public void insert_DuplicateKeyType_IGNORE(Config config) throws Exception {
     DeptDao dao = new DeptDaoImpl(config);
     Dept dept1 = new Dept(new Identity<>(5), 50, "PLANNING", new Location<>("TOKYO"), null);
@@ -494,7 +494,7 @@ public void insert_DuplicateKeyType_IGNORE(Config config) throws Exception {
   }
 
   @Test
-  @Run(unless = {Dbms.SQLSERVER, Dbms.ORACLE})
+  @Run(unless = {Dbms.ORACLE})
   public void insert_DuplicateKeyType_UPDATE_compositeKey(Config config) throws Exception {
     CompKeyDeptDao dao = new CompKeyDeptDaoImpl(config);
     CompKeyDept dept1 =
@@ -545,7 +545,7 @@ public void insert_DuplicateKeyType_UPDATE_compositeKey(Config config) throws Ex
   }
 
   @Test
-  @Run(unless = {Dbms.SQLSERVER, Dbms.ORACLE})
+  @Run(unless = {Dbms.ORACLE})
   public void insert_DuplicateKeyType_IGNORE_compositeKey(Config config) throws Exception {
     CompKeyDeptDao dao = new CompKeyDeptDaoImpl(config);
     CompKeyDept dept1 =

integration-test-java/src/test/java/org/seasar/doma/it/criteria/EntityqlMultiInsertTest.java

@@ -65,7 +65,7 @@ void test() {
   }
 
   @Test
-  @Run(unless = {Dbms.ORACLE, Dbms.SQLSERVER})
+  @Run(unless = {Dbms.ORACLE})
   void testIgnore() {
     Department_ d = new Department_();
 
@@ -112,7 +112,7 @@ void testIgnore() {
   }
 
   @Test
-  @Run(unless = {Dbms.ORACLE, Dbms.SQLSERVER})
+  @Run(unless = {Dbms.ORACLE})
   void testUpdate() {
     Department_ d = new Department_();