Skip to content

Commit 70d320a

Browse files
committed
Revoke support for Dependant annotation.
Because the generated class annotated with Dependant doesn't require a no-args constructor.
1 parent c03dea8 commit 70d320a

File tree

8 files changed

+4
-58
lines changed

8 files changed

+4
-58
lines changed

src/main/java/org/seasar/doma/internal/apt/Options.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,6 @@ public String getCdiApplicationScoped() {
143143
return name != null ? name : Constants.DEFAULT_CDI_APPLICATION_SCOPED;
144144
}
145145

146-
public String getCdiDependent() {
147-
String name = getOption(CDI_DEPENDENT);
148-
return name != null ? name : Constants.DEFAULT_CDI_DEPENDENT;
149-
}
150-
151146
private String getOption(String key) {
152147
String v = options.get(key);
153148
if (v != null) {
@@ -207,7 +202,5 @@ public static class Constants {
207202

208203
public static final String DEFAULT_CDI_APPLICATION_SCOPED =
209204
"javax.enterprise.context.ApplicationScoped";
210-
211-
public static final String DEFAULT_CDI_DEPENDENT = "javax.enterprise.context.Dependent";
212205
}
213206
}

src/main/java/org/seasar/doma/internal/apt/generator/DaoImplGenerator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,12 +136,11 @@ private boolean areJdbcConstructorsRequired() {
136136

137137
private boolean isNoArgConstructorRequired() {
138138
String applicationScoped = ctx.getOptions().getCdiApplicationScoped();
139-
String dependent = ctx.getOptions().getCdiDependent();
140139
for (AnnotationAnnot annotation : daoMeta.getAnnotationMirrors(AnnotationTarget.CLASS)) {
141140
TypeElement typeElement = ctx.getMoreTypes().toTypeElement(annotation.getTypeValue());
142141
if (typeElement != null) {
143142
Name name = typeElement.getQualifiedName();
144-
if (name.contentEquals(applicationScoped) || name.contentEquals(dependent)) {
143+
if (name.contentEquals(applicationScoped)) {
145144
return true;
146145
}
147146
}

src/main/java/org/seasar/doma/internal/apt/processor/DaoProcessor.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@
3333
Options.VERSION_VALIDATION,
3434
Options.RESOURCES_DIR,
3535
Options.CONFIG_PATH,
36-
Options.CDI_APPLICATION_SCOPED,
37-
Options.CDI_DEPENDENT
36+
Options.CDI_APPLICATION_SCOPED
3837
})
3938
public class DaoProcessor extends AbstractGeneratingProcessor<DaoMeta> {
4039

src/main/java/org/seasar/doma/internal/jdbc/dao/AbstractDao.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
public abstract class AbstractDao implements ConfigProvider {
1919

20-
protected Config __config;
20+
protected final Config __config;
2121

2222
protected AbstractDao() {
2323
__config = null;

src/test/java/org/seasar/doma/internal/apt/cdi/Dependent.java

Lines changed: 0 additions & 8 deletions
This file was deleted.

src/test/java/org/seasar/doma/internal/apt/processor/dao/DaoProcessorTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import org.seasar.doma.internal.apt.ResourceParameterResolver;
2020
import org.seasar.doma.internal.apt.SimpleParameterResolver;
2121
import org.seasar.doma.internal.apt.cdi.ApplicationScoped;
22-
import org.seasar.doma.internal.apt.cdi.Dependent;
2322
import org.seasar.doma.internal.apt.processor.DaoProcessor;
2423
import org.seasar.doma.message.Message;
2524

@@ -129,9 +128,7 @@ public Stream<TestTemplateInvocationContext> provideTestTemplateInvocationContex
129128
invocationContext(OnlyDefaultMethodsExtendsDao.class),
130129
invocationContext(
131130
ApplicationScopedDao.class,
132-
"-Adoma.cdi.ApplicationScoped=" + ApplicationScoped.class.getCanonicalName()),
133-
invocationContext(
134-
DependentDao.class, "-Adoma.cdi.Dependent=" + Dependent.class.getName()));
131+
"-Adoma.cdi.ApplicationScoped=" + ApplicationScoped.class.getCanonicalName()));
135132
}
136133

137134
private TestTemplateInvocationContext invocationContext(Class<?> clazz, String... options) {

src/test/java/org/seasar/doma/internal/apt/processor/dao/DependentDao.java

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/test/resources/org/seasar/doma/internal/apt/processor/dao/DaoProcessorTest_DependentDao.txt

Lines changed: 0 additions & 23 deletions
This file was deleted.

0 commit comments

Comments
 (0)