TOP 句を付与する処理をメソッドに切り出し

Author: OdaShinsuke

src/main/java/org/seasar/doma/internal/jdbc/dialect/Mssql2008PagingTransformer.java

@@ -50,9 +50,13 @@ public SqlNode visitSelectStatementNode(SelectStatementNode node, Void p) {
         }
         processed = true;
 
+        return appendTopNode(node);
+    }
+
+    protected SqlNode appendTopNode(SelectStatementNode node) {
         SelectClauseNode select = new SelectClauseNode(node
                 .getSelectClauseNode().getWordNode());
-        select.appendNode(new FragmentNode(" top " + limit));
+        select.appendNode(new FragmentNode(" top (" + limit + ")"));
         for (SqlNode child : node.getSelectClauseNode().getChildren()) {
             select.appendNode(child);
         }
@@ -67,5 +71,4 @@ public SqlNode visitSelectStatementNode(SelectStatementNode node, Void p) {
         result.setForUpdateClauseNode(node.getForUpdateClauseNode());
         return result;
     }
-
 }

src/test/java/org/seasar/doma/internal/jdbc/dialect/Mssql2008PagingTransformerTest.java

@@ -59,7 +59,7 @@ public void testOffsetOnly() throws Exception {
     }
 
     public void testLimitOnly() throws Exception {
-        String expected = "select top 10 emp.id from emp order by emp.id";
+        String expected = "select top (10) emp.id from emp order by emp.id";
         Mssql2008PagingTransformer transformer = new Mssql2008PagingTransformer(
                 -1, 10);
         SqlParser parser = new SqlParser(