Skip to content

Commit 814cc97

Browse files
committed
Support the Sql annotation officially.
The word "experimental" has been removed from the package name.
1 parent 117ecf8 commit 814cc97

File tree

15 files changed

+18
-22
lines changed

15 files changed

+18
-22
lines changed

docs/kotlin-support.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ Embeddable classes
6060
Dao interfaces
6161
--------------
6262
63-
* Specify a SQL template to ``@org.seasar.doma.experimental.Sql``
63+
* Specify a SQL template to ``@org.seasar.doma.Sql``
6464
* Use ``org.seasar.doma.jdbc.Result`` as the return type of ``@Delete``, ``@Insert`` and ``@Update``
6565
* Use ``org.seasar.doma.jdbc.BatchResult`` as the return type of
6666
``@BatchDelete``, ``@BatchInsert`` and ``@BatchUpdate``

docs/sql.rst

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -161,11 +161,6 @@ The ``@Sql`` annotation must be combined with following annotations:
161161
* @BatchUpdate
162162
* @BatchDelete
163163

164-
.. warning::
165-
166-
The ``@Sql`` annotation is an experimental feature.
167-
The full qualified name of ``@Sql`` is ``@org.seasar.doma.experimental.Sql``.
168-
169164
Directives
170165
==========
171166

doma-core/src/main/java/org/seasar/doma/experimental/Sql.java renamed to doma-core/src/main/java/org/seasar/doma/Sql.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package org.seasar.doma.experimental;
1+
package org.seasar.doma;
22

33
import java.lang.annotation.ElementType;
44
import java.lang.annotation.Retention;

doma-core/src/main/java/org/seasar/doma/jdbc/AbstractSqlFileRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import java.lang.reflect.Method;
44
import org.seasar.doma.DomaIllegalArgumentException;
55
import org.seasar.doma.DomaNullPointerException;
6-
import org.seasar.doma.experimental.Sql;
6+
import org.seasar.doma.Sql;
77
import org.seasar.doma.internal.Constants;
88
import org.seasar.doma.internal.WrapException;
99
import org.seasar.doma.internal.jdbc.sql.SqlParser;

doma-core/src/main/java/org/seasar/doma/jdbc/SqlFileRepository.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import java.lang.reflect.Method;
44
import org.seasar.doma.DomaIllegalArgumentException;
55
import org.seasar.doma.DomaNullPointerException;
6+
import org.seasar.doma.Sql;
67
import org.seasar.doma.jdbc.dialect.Dialect;
78

89
/**
@@ -25,9 +26,8 @@ public interface SqlFileRepository {
2526
* @param dialect the SQL dialect
2627
* @return the SQL file
2728
* @throws DomaNullPointerException if any arguments are {@code null}
28-
* @throws DomaIllegalArgumentException if the {@code method} is not annotated with {@link
29-
* org.seasar.doma.experimental.Sql} and the {@code path} does not match the Ant-style glob
30-
* pattern "META-INF/**/*.sql"
29+
* @throws DomaIllegalArgumentException if the {@code method} is not annotated with {@link Sql}
30+
* and the {@code path} does not match the Ant-style glob pattern "META-INF/**/*.sql"
3131
* @throws SqlFileNotFoundException if the SQL file is not found
3232
* @throws JdbcException if an error other than listed above occurs
3333
*/

doma-core/src/main/java/org/seasar/doma/jdbc/query/SqlFileScriptQuery.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public class SqlFileScriptQuery extends AbstractQuery implements ScriptQuery {
2424

2525
protected URL scriptFileUrl;
2626

27-
protected org.seasar.doma.experimental.Sql sqlAnnotation;
27+
protected org.seasar.doma.Sql sqlAnnotation;
2828

2929
protected SqlLogType sqlLogType;
3030

@@ -48,7 +48,7 @@ public void setSqlLogType(SqlLogType sqlLogType) {
4848
public void prepare() {
4949
super.prepare();
5050
assertNotNull(scriptFilePath, blockDelimiter);
51-
sqlAnnotation = method.getAnnotation(org.seasar.doma.experimental.Sql.class);
51+
sqlAnnotation = method.getAnnotation(org.seasar.doma.Sql.class);
5252
if (sqlAnnotation == null) {
5353
assertTrue(scriptFilePath.startsWith(Constants.SCRIPT_PATH_PREFIX));
5454
assertTrue(scriptFilePath.endsWith(Constants.SCRIPT_PATH_SUFFIX));

doma-core/src/test/java/org/seasar/doma/jdbc/AbstractSqlFileRepositoryTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import org.junit.jupiter.api.Test;
88
import org.junit.jupiter.api.TestInfo;
99
import org.seasar.doma.DomaIllegalArgumentException;
10-
import org.seasar.doma.experimental.Sql;
10+
import org.seasar.doma.Sql;
1111
import org.seasar.doma.jdbc.dialect.Dialect;
1212
import org.seasar.doma.jdbc.dialect.StandardDialect;
1313

doma-core/src/test/java/org/seasar/doma/jdbc/query/SqlFileScriptQueryTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import org.junit.jupiter.api.BeforeEach;
1313
import org.junit.jupiter.api.Test;
1414
import org.junit.jupiter.api.TestInfo;
15-
import org.seasar.doma.experimental.Sql;
15+
import org.seasar.doma.Sql;
1616
import org.seasar.doma.internal.jdbc.mock.MockConfig;
1717
import org.seasar.doma.jdbc.ScriptFileNotFoundException;
1818
import org.seasar.doma.jdbc.dialect.Mssql2008Dialect;

doma-processor/src/main/java/org/seasar/doma/internal/apt/annot/Annotations.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
import java.util.function.Function;
99
import javax.lang.model.element.*;
1010
import org.seasar.doma.*;
11+
import org.seasar.doma.Sql;
1112
import org.seasar.doma.experimental.DataType;
12-
import org.seasar.doma.experimental.Sql;
1313
import org.seasar.doma.internal.apt.Context;
1414
import org.seasar.doma.internal.apt.util.AnnotationValueUtil;
1515

doma-processor/src/test/java/org/seasar/doma/internal/apt/processor/dao/experimental/AnnotationConflictDao.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import org.seasar.doma.Dao;
44
import org.seasar.doma.Function;
5-
import org.seasar.doma.experimental.Sql;
5+
import org.seasar.doma.Sql;
66

77
@Dao
88
public interface AnnotationConflictDao {

0 commit comments

Comments
 (0)