Use compareTo instead of equals in BigDecimal comparisons (#927)

* Use `compareTo` instead of `equals` in BigDecimal comparisons

* Pass test with Oracle database

Author: nakamura-to

doma-core/src/main/java/org/seasar/doma/wrapper/BigDecimalWrapper.java

@@ -43,6 +43,18 @@ public void decrement() {
     }
   }
 
+  @Override
+  protected boolean doHasEqualValue(Object otherValue) {
+    BigDecimal value = doGet();
+    if (value == null) {
+      return otherValue == null;
+    }
+    if (otherValue instanceof BigDecimal) {
+      return value.compareTo((BigDecimal) otherValue) == 0;
+    }
+    return false;
+  }
+
   @Override
   public <R, P, Q, TH extends Throwable> R accept(WrapperVisitor<R, P, Q, TH> visitor, P p, Q q)
       throws TH {

doma-core/src/test/java/org/seasar/doma/wrapper/BigDecimalWrapperTest.java

@@ -1,6 +1,8 @@
 package org.seasar.doma.wrapper;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.math.BigDecimal;
 import java.math.BigInteger;
@@ -42,4 +44,11 @@ public void testDecrement() {
     wrapper.decrement();
     assertEquals(new BigDecimal(9), wrapper.get());
   }
+
+  @Test
+  public void testHasEqualValue() {
+    BigDecimalWrapper wrapper = new BigDecimalWrapper(new BigDecimal("10"));
+    assertTrue(wrapper.hasEqualValue(new BigDecimal("10.00")));
+    assertNotEquals(wrapper.get(), new BigDecimal("10.00"));
+  }
 }

integration-test-java/src/main/java/org/seasar/doma/it/dao/EmployeeDao.java

@@ -15,6 +15,7 @@
 import org.seasar.doma.SelectType;
 import org.seasar.doma.Sql;
 import org.seasar.doma.Suppress;
+import org.seasar.doma.Update;
 import org.seasar.doma.it.domain.Hiredate;
 import org.seasar.doma.it.entity.Employee;
 import org.seasar.doma.jdbc.Config;
@@ -150,4 +151,7 @@ default Stream<Employee> streamWithBuilder() {
 
   @Insert
   int insert(Employee entity);
+
+  @Update
+  int update(Employee entity);
 }

integration-test-java/src/test/java/org/seasar/doma/it/auto/AutoUpdateTest.java

@@ -23,6 +23,8 @@
 import org.seasar.doma.it.dao.DepartmentDaoImpl;
 import org.seasar.doma.it.dao.DeptDao;
 import org.seasar.doma.it.dao.DeptDaoImpl;
+import org.seasar.doma.it.dao.EmployeeDao;
+import org.seasar.doma.it.dao.EmployeeDaoImpl;
 import org.seasar.doma.it.dao.NoIdDao;
 import org.seasar.doma.it.dao.NoIdDaoImpl;
 import org.seasar.doma.it.dao.SalesmanDao;
@@ -37,6 +39,7 @@
 import org.seasar.doma.it.entity.CompKeyDepartment;
 import org.seasar.doma.it.entity.Department;
 import org.seasar.doma.it.entity.Dept;
+import org.seasar.doma.it.entity.Employee;
 import org.seasar.doma.it.entity.NoId;
 import org.seasar.doma.it.entity.Salesman;
 import org.seasar.doma.it.entity.Staff;
@@ -254,6 +257,15 @@ public void testUpdate(Config config) throws Exception {
     assertEquals(1, staff.addressId.intValue());
   }
 
+  @Test
+  public void testUpdateUsingOriginalStates(Config config) throws Exception {
+    EmployeeDao dao = new EmployeeDaoImpl(config);
+    Employee employee = dao.selectById(8);
+    employee.setSalary(new Salary(new BigDecimal("3000")));
+    int result = dao.update(employee);
+    assertEquals(0, result);
+  }
+
   @Test
   public void testNestedEntity(Config config) throws Exception {
     BranchDao dao = new BranchDaoImpl(config);