Skip to content

Commit d90c81e

Browse files
committed
Refactor ProcessingContext initialization with factory method
1 parent aa6dffe commit d90c81e

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

doma-processor/src/main/java/org/seasar/doma/internal/apt/DomaProcessor.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,7 @@ public class DomaProcessor extends AbstractProcessor {
9999
@Override
100100
public synchronized void init(ProcessingEnvironment processingEnv) {
101101
super.init(processingEnv);
102-
processingContext = new ProcessingContext(processingEnv);
103-
processingContext.init();
102+
processingContext = ProcessingContext.of(processingEnv);
104103
}
105104

106105
@Override

doma-processor/src/main/java/org/seasar/doma/internal/apt/ProcessingContext.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ public class ProcessingContext {
3030
private Reporter reporter;
3131
private Resources resources;
3232

33-
public ProcessingContext(ProcessingEnvironment env) {
33+
private ProcessingContext(ProcessingEnvironment env) {
3434
this.env = Objects.requireNonNull(env);
3535
}
3636

37-
public void init() {
37+
private void init() {
3838
if (initialized) {
3939
throw new AptIllegalStateException("already initialized");
4040
}
@@ -103,4 +103,11 @@ private void assertInitialized() {
103103
throw new AptIllegalStateException("not yet initialized");
104104
}
105105
}
106+
107+
public static ProcessingContext of(ProcessingEnvironment env) {
108+
Objects.requireNonNull(env);
109+
var processingContext = new ProcessingContext(env);
110+
processingContext.init();
111+
return processingContext;
112+
}
106113
}

doma-processor/src/test/java/org/seasar/doma/internal/apt/TestProcessor.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ protected TestProcessor() {}
4141
@Override
4242
public synchronized void init(ProcessingEnvironment env) {
4343
super.init(env);
44-
ctx = new ProcessingContext(env);
45-
ctx.init();
44+
ctx = ProcessingContext.of(env);
4645
}
4746

4847
@Override

doma-processor/src/test/java/org/seasar/doma/internal/apt/processor/MyAnnotationProcessor.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ public MyAnnotationProcessor(Function<TypeElement, NullElementMeta> handler) {
3838
@Override
3939
public synchronized void init(ProcessingEnvironment processingEnv) {
4040
super.init(processingEnv);
41-
this.ctx = new ProcessingContext(processingEnv);
42-
ctx.init();
41+
this.ctx = ProcessingContext.of(processingEnv);
4342
}
4443

4544
@Override

0 commit comments

Comments
 (0)