Refactor method name for consistency and readability (#1264)

Author: nakamura-to

doma-core/src/main/java/org/seasar/doma/internal/jdbc/sql/NodePreparedSqlBuilder.java

@@ -410,7 +410,7 @@ protected void handleIterableValueNode(
   }
 
   private <E> Iterable<E> applyInListPadding(ValueNode node, Iterable<E> values) {
-    if (node.getInNode() == null || !config.getSqlBuilderSettings().requiresInListPadding()) {
+    if (node.getInNode() == null || !config.getSqlBuilderSettings().shouldRequireInListPadding()) {
       return values;
     }
     Collection<E> valueCollection;

doma-core/src/main/java/org/seasar/doma/jdbc/SqlBuilderSettings.java

@@ -50,11 +50,11 @@ default boolean shouldRemoveBlankLines() {
   }
 
   /**
-   * Indicates whether padding is required for the "IN" list clauses in SQL generation.
+   * Determines whether padding is required for elements in an "IN" list in SQL queries.
    *
-   * @return {@code true} if padding is required; {@code false} otherwise
+   * @return true if padding is required for elements in an "IN" list, false otherwise
    */
-  default boolean requiresInListPadding() {
+  default boolean shouldRequireInListPadding() {
     return false;
   }
 }

doma-core/src/main/java/org/seasar/doma/jdbc/criteria/query/BuilderSupport.java

@@ -627,7 +627,7 @@ private void inTripleSubQuery(
     }
 
     private <E> Iterable<E> applyInListPadding(List<E> list) {
-      if (list.isEmpty() || !config.getSqlBuilderSettings().requiresInListPadding()) {
+      if (list.isEmpty() || !config.getSqlBuilderSettings().shouldRequireInListPadding()) {
         return list;
       }
       int size = list.size();

doma-core/src/test/java/org/seasar/doma/internal/jdbc/sql/SqlParserTest.java

@@ -52,7 +52,7 @@ public SqlBuilderSettings getSqlBuilderSettings() {
           return new SqlBuilderSettings() {
 
             @Override
-            public boolean requiresInListPadding() {
+            public boolean shouldRequireInListPadding() {
               return true;
             }
           };

doma-core/src/test/java/org/seasar/doma/jdbc/criteria/QueryDslSqlSelectTest.java

@@ -90,7 +90,7 @@ public SqlBuilderSettings getSqlBuilderSettings() {
           return new SqlBuilderSettings() {
 
             @Override
-            public boolean requiresInListPadding() {
+            public boolean shouldRequireInListPadding() {
               return true;
             }
           };

integration-test-java/src/test/java/org/seasar/doma/it/criteria/QueryDslEntitySelectTest.java

@@ -443,7 +443,7 @@ public SqlBuilderSettings getSqlBuilderSettings() {
             return new SqlBuilderSettings() {
 
               @Override
-              public boolean requiresInListPadding() {
+              public boolean shouldRequireInListPadding() {
                 return true;
               }
             };
@@ -510,7 +510,7 @@ public SqlBuilderSettings getSqlBuilderSettings() {
             return new SqlBuilderSettings() {
 
               @Override
-              public boolean requiresInListPadding() {
+              public boolean shouldRequireInListPadding() {
                 return true;
               }
             };
@@ -549,7 +549,7 @@ public SqlBuilderSettings getSqlBuilderSettings() {
             return new SqlBuilderSettings() {
 
               @Override
-              public boolean requiresInListPadding() {
+              public boolean shouldRequireInListPadding() {
                 return true;
               }
             };

integration-test-java/src/test/java/org/seasar/doma/it/sql/SqlSelectTest.java

@@ -48,7 +48,7 @@ public SqlBuilderSettings getSqlBuilderSettings() {
             return new SqlBuilderSettings() {
 
               @Override
-              public boolean requiresInListPadding() {
+              public boolean shouldRequireInListPadding() {
                 return true;
               }
             };