5.14.1

Make the DMARC `p` tag required again until DMARCbis is released

Author: seanthegeek

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 5.14.1
+
+### Fixes
+
+- Make the DMARC `p` tag required again until DMARCbis is released with an RFC number.
+
 ## 5.14.0
 
 ### DMARCbis changes

checkdmarc/_constants.py

@@ -19,7 +19,7 @@
 See the License for the specific language governing permissions and
 limitations under the License."""
 
-__version__ = "5.14.0"
+__version__ = "5.14.1"
 
 OS = platform.system()
 OS_RELEASE = platform.release()

checkdmarc/dmarc.py

@@ -434,7 +434,7 @@ class DMARCErrorData(TypedDict, total=False):
     },
     "p": {
         "name": "Requested Mail Receiver Policy",
-        "required": False,
+        "required": True,
         "description": (
             "Specifies the policy to "
             "be enacted by the "
@@ -1342,11 +1342,12 @@ def parse_dmarc_record(
         if tag not in tags and "default" in dmarc_tags[tag]:
             tags[tag] = {"value": dmarc_tags[tag]["default"], "explicit": False}
     if "p" not in tags:
-        tags["p"] = {"value": "none", "explicit": False}
-        warnings.append(
-            "The p tag is optional in DMARCbis, but is required "
-            "in older versions of DMARC."
-        )
+        raise DMARCSyntaxError('The record is missing the required policy ("p") tag.')
+    # tags["p"] = {"value": "none", "explicit": False}
+    # warnings.append(
+    #  "A missing p tag is equivalent to p=none in DMARCbis, "
+    # "but a p tag is required in older versions of DMARC."
+    # )
     tags["p"]["value"] = tags["p"]["value"].lower()
     if "sp" not in tags:
         tags["sp"] = {"value": tags["p"]["value"], "explicit": False}