Skip to content

Commit 0bf691d

Browse files
committed
5.11.6
- Remove inaccurate warning about SMTP-STS policy line endings - Clarify DMARC `none` policy warnings
1 parent 3c25456 commit 0bf691d

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
## 5.11.6
4+
5+
- Remove inaccurate warning about SMTP-STS policy line endings
6+
- Clarify DMARC `none` policy warnings
7+
38
## 5.11.5
49

510
- Allow for matching subdomain or base domain when validating VMCs

checkdmarc/dmarc.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -921,11 +921,11 @@ def parse_dmarc_record(
921921
allowed_values = dmarc_tags[tag]["values"]
922922
if tag == "p" and tag_value == "none":
923923
warnings.append(
924-
f"A p tag value of none has no effect on email sent as {domain}."
924+
f"A p tag value of none makes DMARC ineffective on email sent as {domain}."
925925
)
926926
if tag == "sp" and tag_value == "none" and explicit:
927927
warnings.append(
928-
f"An sp tag value of none has no effect on email sent as a subdomain of {domain}."
928+
f"An sp tag value of none makes DMARC ineffective on email sent as a subdomain of {domain}."
929929
)
930930
if tag == "fo":
931931
tag_value = tag_value.split(":")

checkdmarc/mta_sts.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,6 @@ def parse_mta_sts_policy(policy: str) -> OrderedDict:
379379
acceptable_keys = required_keys.copy()
380380
acceptable_keys.append("mx")
381381
if "\n" in policy and "\r\n" not in policy:
382-
warnings.append("MTA-STS policy lines should end with CRLF not LF.")
383382
policy = policy.replace("\n", "\r\n")
384383
lines = policy.split("\r\n")
385384
for i in range(len(lines)):

0 commit comments

Comments
 (0)