5.12.12

- Do not attempt to include an SMTP error code when none is provided (Close #189)

Author: seanthegeek

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 5.12.12
+
+- Do not attempt to include an SMTP error code when none is provided (Close #189)
+
 ## 5.12.11
 
 - Remove unneeded `finally` blocks in `smtp.py` that were causing warnings in Python 3.14 (Close #178)

checkdmarc/_constants.py

@@ -19,7 +19,7 @@
 See the License for the specific language governing permissions and
 limitations under the License."""
 
-__version__ = "5.12.11"
+__version__ = "5.12.12"
 
 OS = platform.system()
 OS_RELEASE = platform.release()

checkdmarc/smtp.py

@@ -181,8 +181,11 @@ def test_tls(
         raise SMTPError(error)
     except smtplib.SMTPException as e:
         error = e.__str__()
-        error_code = error.lstrip("(").split(",")[0]
-        error = f"SMTP error code {error_code}"
+        try:
+            error_code = error.lstrip("(").split(",")[0]
+            error = f"SMTP error code {error_code}"
+        except ValueError:
+            pass
         if cache:
             cache[hostname] = dict(tls=False, error=error)
         raise SMTPError(error)
@@ -300,9 +303,12 @@ def test_starttls(
             cache[hostname] = dict(starttls=False, error=error)
         raise SMTPError(error)
     except smtplib.SMTPException as e:
-        message = e.__str__()
-        error_code = int(message.lstrip("(").split(",")[0])
-        error = f"SMTP error code {error_code}"
+        error = e.__str__()
+        try:
+            error_code = error.lstrip("(").split(",")[0]
+            error = f"SMTP error code {error_code}"
+        except ValueError:
+            pass
         if cache:
             cache[hostname] = dict(starttls=False, error=error)
         raise SMTPError(error)