Skip to content

Commit 62e3207

Browse files
authored
Fixing a bug in policy/subdomain policy check for parked domains (#167)
1 parent 4192b7f commit 62e3207

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

checkdmarc/dmarc.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1065,10 +1065,10 @@ def parse_dmarc_record(
10651065
"monitor results instead"
10661066
)
10671067
warnings.append(str(_DMARCBestPracticeWarning(warning_msg)))
1068-
if parked and tags["p"] != "reject":
1068+
if parked and tags["p"]["value"] != "reject":
10691069
warning_msg = "Policy (p=) should be reject for parked domains"
10701070
warnings.append(str(_DMARCBestPracticeWarning(warning_msg)))
1071-
if parked and tags["sp"] != "reject":
1071+
if parked and tags["sp"]["value"] != "reject":
10721072
warning_msg = "Subdomain policy (sp=) should be reject for " "parked domains"
10731073
warnings.append(str(_DMARCBestPracticeWarning(warning_msg)))
10741074

0 commit comments

Comments
 (0)