Fix tests

martincostello · martincostello · commit d16dbd7aff00 · 2025-05-16T13:08:47.000-04:00
Fix tests due to error in test setup fixture caused by changes in microsoft/OpenAPI.NET#2325.
diff --git a/test/Swashbuckle.AspNetCore.IntegrationTests/snapshots/VerifyTests.SwaggerEndpoint_ReturnsValidSwaggerJson_startupType=TestFirst.Startup_swaggerRequestUri=v1-generated.DotNet10_0.verified.txt b/test/Swashbuckle.AspNetCore.IntegrationTests/snapshots/VerifyTests.SwaggerEndpoint_ReturnsValidSwaggerJson_startupType=TestFirst.Startup_swaggerRequestUri=v1-generated.DotNet10_0.verified.txt
@@ -7,9 +7,6 @@
   "paths": {
     "/api/users": {
       "post": {
-        "tags": [
-          "Users"
-        ],
         "operationId": "CreateUser",
         "requestBody": {
           "content": {
diff --git a/test/Swashbuckle.AspNetCore.IntegrationTests/snapshots/VerifyTests.SwaggerEndpoint_ReturnsValidSwaggerJson_startupType=TestFirst.Startup_swaggerRequestUri=v1-generated.DotNet8_0.verified.txt b/test/Swashbuckle.AspNetCore.IntegrationTests/snapshots/VerifyTests.SwaggerEndpoint_ReturnsValidSwaggerJson_startupType=TestFirst.Startup_swaggerRequestUri=v1-generated.DotNet8_0.verified.txt
@@ -7,9 +7,6 @@
   "paths": {
     "/api/users": {
       "post": {
-        "tags": [
-          "Users"
-        ],
         "operationId": "CreateUser",
         "requestBody": {
           "content": {
diff --git a/test/Swashbuckle.AspNetCore.IntegrationTests/snapshots/VerifyTests.SwaggerEndpoint_ReturnsValidSwaggerJson_startupType=TestFirst.Startup_swaggerRequestUri=v1-generated.DotNet9_0.verified.txt b/test/Swashbuckle.AspNetCore.IntegrationTests/snapshots/VerifyTests.SwaggerEndpoint_ReturnsValidSwaggerJson_startupType=TestFirst.Startup_swaggerRequestUri=v1-generated.DotNet9_0.verified.txt
@@ -7,9 +7,6 @@
   "paths": {
     "/api/users": {
       "post": {
-        "tags": [
-          "Users"
-        ],
         "operationId": "CreateUser",
         "requestBody": {
           "content": {
diff --git a/test/WebSites/TestFirst.IntegrationTests/CreateProductTests.cs b/test/WebSites/TestFirst.IntegrationTests/CreateProductTests.cs
@@ -6,10 +6,10 @@
 
 namespace TestFirst.IntegrationTests;
 
-public class CreateProductTests(ApiTestRunner apiTestRunner, WebApplicationFactory<TestFirst.Startup> webApplicationFactory)
-    : ApiTestFixture<TestFirst.Startup>(apiTestRunner, webApplicationFactory, "v1-imported")
+public class CreateProductTests(ApiTestRunner apiTestRunner, WebApplicationFactory<Startup> webApplicationFactory)
+    : ApiTestFixture<Startup>(apiTestRunner, webApplicationFactory, "v1-imported")
 {
-    [Fact(Skip = "Disabled due to issue with truncated OpenAPI document")]
+    [Fact]
     public async Task CreateProduct_Returns201_IfContentIsValid()
     {
         await TestAsync(
@@ -27,7 +27,7 @@ await TestAsync(
         );
     }
 
-    [Fact(Skip = "Disabled due to issue with truncated OpenAPI document")]
+    [Fact]
     public async Task CreateProduct_Returns400_IfContentIsInValid()
     {
         await TestAsync(
diff --git a/test/WebSites/TestFirst.IntegrationTests/CreateUserTests.cs b/test/WebSites/TestFirst.IntegrationTests/CreateUserTests.cs
@@ -2,15 +2,14 @@
 using Microsoft.AspNetCore.Mvc.Testing;
 using Microsoft.OpenApi.Models;
 using Microsoft.OpenApi.Models.Interfaces;
-using Microsoft.OpenApi.Models.References;
 using Newtonsoft.Json;
 using Swashbuckle.AspNetCore;
 using Swashbuckle.AspNetCore.ApiTesting.Xunit;
 using Xunit;
 
 namespace TestFirst.IntegrationTests;
 
-public class CreateUserTests : ApiTestFixture<TestFirst.Startup>
+public class CreateUserTests : ApiTestFixture<Startup>
 {
     public CreateUserTests(
         ApiTestRunner apiTestRunner,
@@ -20,7 +19,6 @@ public CreateUserTests(
         Describe("/api/users", HttpMethod.Post, new OpenApiOperation
         {
             OperationId = "CreateUser",
-            Tags = [new OpenApiTagReference("Users")],
             RequestBody = new OpenApiRequestBody
             {
                 Content = new Dictionary<string, OpenApiMediaType>
@@ -63,7 +61,7 @@ public CreateUserTests(
         });
     }
 
-    [Fact(Skip = "Disabled due to issue with truncated OpenAPI document")]
+    [Fact]
     public async Task CreateUser_Returns201_IfContentIsValid()
     {
         await TestAsync(
@@ -81,7 +79,7 @@ await TestAsync(
         );
     }
 
-    [Fact(Skip = "Disabled due to issue with truncated OpenAPI document")]
+    [Fact]
     public async Task CreateUser_Returns400_IfContentIsInValid()
     {
         await TestAsync(
diff --git a/test/WebSites/TestFirst.IntegrationTests/GetProductsTests.cs b/test/WebSites/TestFirst.IntegrationTests/GetProductsTests.cs
@@ -4,16 +4,12 @@
 
 namespace TestFirst.IntegrationTests;
 
-public class GetProductsTests : ApiTestFixture<TestFirst.Startup>
+public class GetProductsTests(ApiTestRunner apiTestRunner, WebApplicationFactory<Startup> webApplicationFactory)
+    : ApiTestFixture<Startup>(apiTestRunner, webApplicationFactory, "v1-imported")
 {
-    public GetProductsTests(
-        ApiTestRunner apiTestRunner,
-        WebApplicationFactory<TestFirst.Startup> webApplicationFactory)
-        : base(apiTestRunner, webApplicationFactory, "v1-imported")
-    { }
 
-    [Fact(Skip = "Disabled due to issue with truncated OpenAPI document")]
-    public async Task GetProducsts_Returns200_IfRequiredParametersProvided()
+    [Fact]
+    public async Task GetProducts_Returns200_IfRequiredParametersProvided()
     {
         await TestAsync(
             "GetProducts",
@@ -26,7 +22,7 @@ await TestAsync(
         );
     }
 
-    [Fact(Skip = "Disabled due to issue with truncated OpenAPI document")]
+    [Fact]
     public async Task GetProducts_Returns400_IfRequiredParametersMissing()
     {
         await TestAsync(
diff --git a/test/WebSites/TestFirst/wwwroot/swagger/v1-generated/openapi.json b/test/WebSites/TestFirst/wwwroot/swagger/v1-generated/openapi.json
@@ -7,9 +7,6 @@
   "paths": {
     "/api/users": {
       "post": {
-        "tags": [
-          "Users"
-        ],
         "operationId": "CreateUser",
         "requestBody": {
           "content": {
diff --git a/test/WebSites/TestFirst/wwwroot/swagger/v1-imported/openapi.json b/test/WebSites/TestFirst/wwwroot/swagger/v1-imported/openapi.json
@@ -123,5 +123,11 @@
         }
       }
     }
-  }
+  },
+  "tags": [
+    {
+      "name": "Products",
+      "description": "Operations about products"
+    }
+  ]
 }

Original file line number	Diff line number	Diff line change
`@@ -6,10 +6,10 @@`
`6`	`6`
`7`	`7`	`namespace TestFirst.IntegrationTests;`
`8`	`8`
`9`		`-public class CreateProductTests(ApiTestRunner apiTestRunner, WebApplicationFactory<TestFirst.Startup> webApplicationFactory)`
`10`		`- : ApiTestFixture<TestFirst.Startup>(apiTestRunner, webApplicationFactory, "v1-imported")`
	`9`	`+public class CreateProductTests(ApiTestRunner apiTestRunner, WebApplicationFactory<Startup> webApplicationFactory)`
	`10`	`+ : ApiTestFixture<Startup>(apiTestRunner, webApplicationFactory, "v1-imported")`
`11`	`11`	`{`
`12`		`- [Fact(Skip = "Disabled due to issue with truncated OpenAPI document")]`
	`12`	`+ [Fact]`
`13`	`13`	`public async Task CreateProduct_Returns201_IfContentIsValid()`
`14`	`14`	`{`
`15`	`15`	`await TestAsync(`
`@@ -27,7 +27,7 @@ await TestAsync(`
`27`	`27`	`);`
`28`	`28`	`}`
`29`	`29`
`30`		`- [Fact(Skip = "Disabled due to issue with truncated OpenAPI document")]`
	`30`	`+ [Fact]`
`31`	`31`	`public async Task CreateProduct_Returns400_IfContentIsInValid()`
`32`	`32`	`{`
`33`	`33`	`await TestAsync(`
Original file line number	Diff line number	Diff line change
`@@ -2,15 +2,14 @@`
`2`	`2`	`using Microsoft.AspNetCore.Mvc.Testing;`
`3`	`3`	`using Microsoft.OpenApi.Models;`
`4`	`4`	`using Microsoft.OpenApi.Models.Interfaces;`
`5`		`-using Microsoft.OpenApi.Models.References;`
`6`	`5`	`using Newtonsoft.Json;`
`7`	`6`	`using Swashbuckle.AspNetCore;`
`8`	`7`	`using Swashbuckle.AspNetCore.ApiTesting.Xunit;`
`9`	`8`	`using Xunit;`
`10`	`9`
`11`	`10`	`namespace TestFirst.IntegrationTests;`
`12`	`11`
`13`		`-public class CreateUserTests : ApiTestFixture<TestFirst.Startup>`
	`12`	`+public class CreateUserTests : ApiTestFixture<Startup>`
`14`	`13`	`{`
`15`	`14`	`public CreateUserTests(`
`16`	`15`	`ApiTestRunner apiTestRunner,`
`@@ -20,7 +19,6 @@ public CreateUserTests(`
`20`	`19`	`Describe("/api/users", HttpMethod.Post, new OpenApiOperation`
`21`	`20`	`{`
`22`	`21`	`OperationId = "CreateUser",`
`23`		`- Tags = [new OpenApiTagReference("Users")],`
`24`	`22`	`RequestBody = new OpenApiRequestBody`
`25`	`23`	`{`
`26`	`24`	`Content = new Dictionary<string, OpenApiMediaType>`
`@@ -63,7 +61,7 @@ public CreateUserTests(`
`63`	`61`	`});`
`64`	`62`	`}`
`65`	`63`
`66`		`- [Fact(Skip = "Disabled due to issue with truncated OpenAPI document")]`
	`64`	`+ [Fact]`
`67`	`65`	`public async Task CreateUser_Returns201_IfContentIsValid()`
`68`	`66`	`{`
`69`	`67`	`await TestAsync(`
`@@ -81,7 +79,7 @@ await TestAsync(`
`81`	`79`	`);`
`82`	`80`	`}`
`83`	`81`
`84`		`- [Fact(Skip = "Disabled due to issue with truncated OpenAPI document")]`
	`82`	`+ [Fact]`
`85`	`83`	`public async Task CreateUser_Returns400_IfContentIsInValid()`
`86`	`84`	`{`
`87`	`85`	`await TestAsync(`
Original file line number	Diff line number	Diff line change
`@@ -123,5 +123,11 @@`
`123`	`123`	`}`
`124`	`124`	`}`
`125`	`125`	`}`
`126`		`- }`
	`126`	`+ },`
	`127`	`+ "tags": [`
	`128`	`+ {`
	`129`	`+ "name": "Products",`
	`130`	`+ "description": "Operations about products"`
	`131`	`+ }`
	`132`	`+ ]`
`127`	`133`	`}`