Skip to content

Commit 2e21b41

Browse files
committed
Use "\n" newlines by default for testing.check_file_output
1 parent 0ed64ab commit 2e21b41

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

domdf_python_tools/testing.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,6 +497,7 @@ def check_file_output(
497497
filename: PathLike,
498498
file_regression: FileRegressionFixture,
499499
extension: Optional[str] = None,
500+
newline: Optional[str] = '\n',
500501
**kwargs,
501502
):
502503
r"""
@@ -505,9 +506,12 @@ def check_file_output(
505506
:param filename:
506507
:param file_regression: The file regression fixture for the test.
507508
:param extension: The extension of the reference file.
509+
:param newline: Controls how universal newlines mode works. See :func:`open`.
508510
:param \*\*kwargs: Additional keyword arguments passed to :meth:`.FileRegressionFixture.check`.
509511
510512
.. versionadded:: 1.5.0
513+
514+
.. versionchanged:: 1.7.1 Changed the default for ``newline`` to ``'\n'``.
511515
"""
512516

513517
filename = PathPlus(filename)
@@ -518,4 +522,4 @@ def check_file_output(
518522
if extension == ".py":
519523
extension = "._py_"
520524

521-
return check_file_regression(data, file_regression, extension, **kwargs)
525+
return check_file_regression(data, file_regression, extension, newline=newline, **kwargs)

0 commit comments

Comments
 (0)